Year-end triage of WPT test expectations |
||
Issue descriptionI've noticed a lot of unnecessarily wide (or even wrong) expectation lines for WPT. Time for some house cleaning and see if there's any pattern.
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c77fa78a7204d4f4fa71020b96b8e2ceee7bc8e2 commit c77fa78a7204d4f4fa71020b96b8e2ceee7bc8e2 Author: Robert Ma <robertma@chromium.org> Date: Wed Dec 20 21:59:57 2017 Adjust expectations for wpt/css-fonts/matching There are in fact two separate issues, one on Mac10.12 and the other on Win10. Other platforms are not affected. TBR=drott Bug: 752449, 796619, 796617 Change-Id: Ic678d919015066a242430977175f62af5f5302e2 Reviewed-on: https://chromium-review.googlesource.com/836934 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#525482} [modify] https://crrev.com/c77fa78a7204d4f4fa71020b96b8e2ceee7bc8e2/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c88083dcc024bfbf979b36a186ba781456b53612 commit c88083dcc024bfbf979b36a186ba781456b53612 Author: Robert Ma <robertma@chromium.org> Date: Wed Dec 20 22:12:20 2017 Simplify platform specifiers of some expectations Most of these were artifacts when we fiddled with platform specifier simplification or when Mac10.13 was newly added. Also change the linked bug of an encoding test to the more specific one. Bug: 736056 , 796617 Change-Id: I86fa7980eee86790503d62d7368a745da08a905f Reviewed-on: https://chromium-review.googlesource.com/837680 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#525489} [modify] https://crrev.com/c88083dcc024bfbf979b36a186ba781456b53612/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddd51a355760d18cb6f17318ed2caef07c7eed61 commit ddd51a355760d18cb6f17318ed2caef07c7eed61 Author: Chris Nardi <hichris123@gmail.com> Date: Fri Dec 22 05:32:53 2017 Remove consistently passing tests from TestExpectations From the flakiness dashboard, these tests appeared to be consistently passing on all platforms. This change removes the expectation lines for each passing test. Bug: 796617 Change-Id: I13a4aaa1f5c44477ecd4dc3704d2e33cbe9557d9 Reviewed-on: https://chromium-review.googlesource.com/840617 Commit-Queue: Chris Nardi <hichris123@gmail.com> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#525938} [modify] https://crrev.com/ddd51a355760d18cb6f17318ed2caef07c7eed61/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7da3a94fab6ffc2f4865d5c00654a0addb4f86dc commit 7da3a94fab6ffc2f4865d5c00654a0addb4f86dc Author: Robert Ma <robertma@chromium.org> Date: Fri Dec 22 15:42:02 2017 Re-enable feature policy tests And fix a typo in a test along the way. Bug: 732003 , 796617 Change-Id: I9df6fb630139e1a2534c174c20804111a9189a31 Reviewed-on: https://chromium-review.googlesource.com/841264 Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#525996} [modify] https://crrev.com/7da3a94fab6ffc2f4865d5c00654a0addb4f86dc/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/7da3a94fab6ffc2f4865d5c00654a0addb4f86dc/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforall.php
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d2dea7990db75ea2abcf39b58aa37104b3badad commit 8d2dea7990db75ea2abcf39b58aa37104b3badad Author: Chris Nardi <hichris123@gmail.com> Date: Wed Jan 10 14:27:29 2018 Remove passing WPT tests from TestExpectations and NeverFixTests Some WPT tests were disabled on their import, but fixed upstream afterwards. Enable these now-passing tests. Bug: 796617 Change-Id: Ic4995d23971aa6faecead1e0bf8dc2a2df70e4cf Reviewed-on: https://chromium-review.googlesource.com/846505 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#528306} [modify] https://crrev.com/8d2dea7990db75ea2abcf39b58aa37104b3badad/third_party/WebKit/LayoutTests/NeverFixTests [modify] https://crrev.com/8d2dea7990db75ea2abcf39b58aa37104b3badad/third_party/WebKit/LayoutTests/TestExpectations
,
Jan 24 2018
,
Apr 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/184cf0d0742fb8e3224410fa32b85704df511d5b commit 184cf0d0742fb8e3224410fa32b85704df511d5b Author: Chris Nardi <cnardi@chromium.org> Date: Sun Apr 22 19:07:45 2018 Re-enable css/css-style-attr/style-attr-braces-002-quirks.htm https://github.com/w3c/web-platform-tests/pull/9670 fixed https://github.com/w3c/web-platform-tests/issues/8633, so the test now passes. As such, re-enable the test. TBR=foolip@chromium.org Bug: 796617 Change-Id: I9a864ab588c141ee5c48474e491a90bbe4f82b1a Reviewed-on: https://chromium-review.googlesource.com/1023598 Reviewed-by: Chris Nardi <cnardi@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#552609} [modify] https://crrev.com/184cf0d0742fb8e3224410fa32b85704df511d5b/third_party/WebKit/LayoutTests/NeverFixTests
,
Jan 10
This is great work, however when deleting the lines from the file it would have been good to ping all of the referenced bugs, since some of them can be closed. One of them popped up for re-triage and I was surpised to find that it was no longer disabled. I did a git bisect to find out what happened. I notified 2 bugs: 699096, 781595 since ddd51a355760d18cb6f17318ed2caef07c7eed61 removed all references from TestExpectations. I didn't do anything else. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Dec 20 2017