New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 796606 link

Starred by 1 user
Status: WontFix
Owner:
tapted@chromium.org
Closed: Jun 2018
Cc:
█ spqc...@chromium.org
tapted@chromium.org
█ shrike@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: The Omnibox hover buttons have no longer 1pt space between its border and the Omnibox border

Project Member Reported by meh...@chromium.org, Dec 20 2017 
Chrome Version: Chrome Canary 65.0.3299.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Visit a page
(2) Hover over the Security indicator

What is the expected result?
The Omnibox hover buttons should have 1pt space between its border and the Omnibox border.

What happens instead?
The Omnibox hover buttons have no longer 1pt space between its border and the Omnibox border.

Please find attached two screenshots (actual vs expected).

tapted@: This was probably cause by https://chromium-review.googlesource.com/c/chromium/src/+/773718 to avoid the Omnibox shrinking when it has focus.

Without the 1pt space it looking also fine to me, but I just only want to be sure, what is the intended behavior here.

Thanks,
Mehmet
Chrome_Canary_actual.png
15.6 KB View Download
Chrome_Canary_expected.png
16.0 KB View Download

Comment 1 by jdonnelly@chromium.org, Dec 20 2017

Components: UI>Browser>Omnibox

Comment 2 by tapted@chromium.org, Dec 20 2017

Labels: -Pri-1 Hotlist-Polish Pri-2
Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
I think currently on retina there is still a gap: 1 DIP (2 pixels) when the omnibox doesn't have focus, and 1 pixel from the focus ring (still 1 DIP to the border) when it does have focus.

And of course, since the omnibox would previously shrink when it did have focus, this gap would change. Now at least the gap is constant :).

There's probably something to investigate for non-retina, but I don't think it's high priority. We probably don't want the maintenance cost for another non-retina codepath to fix this, but maybe there's some cleanup that can be done.

Comment 3 by tapted@chromium.org, Jun 27 2018

Status: WontFix (was: Assigned)
obsolete
►

Sign in to add a comment