New issue
Advanced search Search tips

Issue 796596 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 598073



Sign in to add a comment

Add network service tests to CQ and main waterfall

Project Member Reported by jam@chromium.org, Dec 20 2017

Issue description

Now that the old navigation code path is off the CQ and main waterfall (r525086), we should add the network service.
 

Comment 1 by jam@chromium.org, Dec 20 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18058236cedf5d303490bda82027ea1a8b0c696b

commit 18058236cedf5d303490bda82027ea1a8b0c696b
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Dec 21 03:55:09 2017

Increase network_service_browser_tests sharding to 10 from 5.

This matches browser_tests on the bot. It will also alleviate timeouts on the 32 bit debug bot.

TBR=dpranke@chromium.org

Bug:  796596 
Change-Id: I8f38baea3a9999ecab96b402074e8fa63c63fbba
Reviewed-on: https://chromium-review.googlesource.com/838257
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525593}
[modify] https://crrev.com/18058236cedf5d303490bda82027ea1a8b0c696b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/18058236cedf5d303490bda82027ea1a8b0c696b/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/18058236cedf5d303490bda82027ea1a8b0c696b/testing/buildbot/chromium.sandbox.json
[modify] https://crrev.com/18058236cedf5d303490bda82027ea1a8b0c696b/testing/buildbot/test_suites.pyl

Re #2: This caused flaky failures on network_service_browser_tests on Linux Tests.

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/69104

Comment 5 by jam@chromium.org, Dec 21 2017

Thanks for the report, we've disabled that test in r525537.

Comment 6 by jam@chromium.org, Jan 17 2018

Status: Fixed (was: Started)

Sign in to add a comment