New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796584 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Ensure free-standing wasm tables are rooted in importing instances

Project Member Reported by mtrofin@chromium.org, Dec 20 2017

Issue description

Status: Started (was: Untriaged)
Cc: hablich@chromium.org
Labels: Restrict-View-SecurityTeam
Labels: -Restrict-View-Google
Tightened access. The issue is a security one - invalid memory accesses.
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 22 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-64
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 4 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please add affected OSs.
Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows
Cc: awhalley@chromium.org
Labels: -Merge-Review-64 Merge-Approved-64
Labels: -OS-iOS
Please merge the approved cl(s) to M64 release branch 3282 as soon as possible.
Owner: bradnelson@chromium.org
+Brad for the merge.
Please merge this today
This one needs a rebase in order to merge it.

Comment 18 by cmasso@google.com, Jan 12 2018

Labels: -Hotlist-Merge-Review
 titzer@ please take care of this
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 15 2018

Labels: merge-merged-6.4
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/62dce33fd852c79062111906cf09f1cfecfe1c6e

commit 62dce33fd852c79062111906cf09f1cfecfe1c6e
Author: Ben L. Titzer <titzer@google.com>
Date: Mon Jan 15 18:21:34 2018

Merged: [wasm] Ensure free-standing tables are rooted.

Revision: f9c9616e622cb712841b1151483fe8d7ff844100

BUG= chromium:796584 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=mlippautz@chromium.org

Change-Id: I5e4a4a4fb6bea1821558d8a8d8baa88ca08f26f7
Reviewed-on: https://chromium-review.googlesource.com/867373
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.4@{#55}
Cr-Branched-From: 0407506af3d9d7e2718be1d8759296165b218fcf-refs/heads/6.4.388@{#1}
Cr-Branched-From: a5fc4e085ee543cb608eb11034bc8f147ba388e1-refs/heads/master@{#49724}
[modify] https://crrev.com/62dce33fd852c79062111906cf09f1cfecfe1c6e/src/wasm/module-compiler.cc
[modify] https://crrev.com/62dce33fd852c79062111906cf09f1cfecfe1c6e/src/wasm/wasm-objects-inl.h
[modify] https://crrev.com/62dce33fd852c79062111906cf09f1cfecfe1c6e/src/wasm/wasm-objects.h
[modify] https://crrev.com/62dce33fd852c79062111906cf09f1cfecfe1c6e/test/mjsunit/wasm/indirect-tables.js

Labels: -Merge-Approved-64
Project Member

Comment 21 by sheriffbot@chromium.org, Mar 30 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment