Issue metadata
Sign in to add a comment
|
1 new static initializer (MonochromePublic.apk) at 525076:525076 |
||||||||||||||||||||
Issue descriptionCaused by “Update Android NDK to r16” Commit: 2c1e00697d3c3d087f4d84eaf2c4c40a3e7a0530 Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=525076 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase Is there a way to avoid adding the new static initializer?
,
Dec 20 2017
Original CL has been reverted, but for a different reason. Thus this bug is good to fix for the reland.
,
Dec 20 2017
I'm not sure how feasible it is to avoid adding the new SI, although I could certainly be wrong. AFAIK, it comes from the NDK itself, and not the Chromium changes that were necessary to make it compatible with the newer NDK. Andrew, what's your opinion on modifying the NDK code to remove the SI, if it's even possible?
,
Dec 20 2017
From running supersize diff on the ndk commit:
Static Initializers Diff:
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
+ 0) 384 (101.1%) t@0x30fcc0 384 (0->372) v8/src/parsing/token.cc
startup
~ 1) 380 (100.0%) t@0x318768 -4 (52->48) third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_static.a/iostream.o
startup
Looks like the new one is actually from v8. Not sure why this changes with the ndk though. Also - the file only has primitives:
https://cs.chromium.org/chromium/src/v8/src/parsing/token.cc?q=parsing/token.cc
I'd guess we should just let this slide for now. It's not like we're at 0 SIs already, and there's nothing here that looks too harmful. Eventually someone might take on the initiative to get us to 0 SIs, but until then we're just operating at best-effort.
,
Jan 10 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 20 2017