New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796575 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 794961



Sign in to add a comment

HostFrameSinkManager::CreateRootCompositorFrameSink Crash

Project Member Reported by jonr...@chromium.org, Dec 20 2017

Issue description

So far only seen on Chrome OS, but it's possible for viz::HostFrameSinkManager::CreateRootCompositorFrameSink to crash with the following failed check:

Check failed: !data.HasCompositorFrameSinkData()

This can be reproduced with the browser_tests case WebSocketBrowserTest.WebSocketBasicAuthInHTTPSURL

 
Err... I mean:

ForceMaximizeOnFirstRunTest.*TwoRuns

TODO: jonross update what this crash is, CrOS only
Owner: kylec...@chromium.org
Status: Assigned (was: Untriaged)
Cc: fsam...@chromium.org
+fsamuel@ (SurfaceInvariants)

As noted this tests is a CrOS one.

The current crash is SurfaceInvariants

ERROR:root_compositor_frame_sink_impl.cc(121)] SubmitCompositorFrame failed for LocalSurfaceId(1, 1, 6946...) because Surface invariants violation
[62718:62718:0312/135601.693207:FATAL:client_layer_tree_frame_sink.cc(221)] Surface invariants violation
#0 0x7f0d2258b32c base::debug::StackTrace::StackTrace()
#1 0x7f0d225b1fac logging::LogMessage::~LogMessage()
#2 0x7f0d14f7ab55 viz::ClientLayerTreeFrameSink::OnMojoConnectionError()
#3 0x7f0d14f7d25c _ZN4base8internal7InvokerINS0_9BindStateIMN3viz24ClientLayerTreeFrameSinkEFvjRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEEEJNS_7WeakPtrIS4_EEEEEFvjSD_EE3RunEPNS0_13BindStateBaseEjSD_
#4 0x7f0d1fd6cb9c mojo::InterfaceEndpointClient::NotifyError()
#5 0x7f0d1fd73af8 mojo::internal::MultiplexRouter::ProcessNotifyErrorTask()
#6 0x7f0d1fd70acd mojo::internal::MultiplexRouter::ProcessTasks()
#7 0x7f0d1fd7257d mojo::internal::MultiplexRouter::Accept()
#8 0x7f0d1fd6af96 mojo::FilterChain::Accept()
#9 0x7f0d1fd66125 mojo::Connector::ReadSingleMessage()
#10 0x7f0d1fd66b61 mojo::Connector::ReadAllAvailableMessages()
#11 0x7f0d1fd66a09 mojo::Connector::OnHandleReadyInternal()
#12 0x7f0d1fd67297 mojo::SimpleWatcher::DiscardReadyState()
#13 0x7f0d1fd2ee16 mojo::SimpleWatcher::OnHandleReady()
#14 0x7f0d1fd2f321 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
#15 0x7f0d2258bc14 base::debug::TaskAnnotator::RunTask()
#16 0x7f0d225bcd79 base::internal::IncomingTaskQueue::RunTask()
#17 0x7f0d225c098b base::MessageLoop::RunTask()
#18 0x7f0d225c0d2a base::MessageLoop::DeferOrRunPendingTask()
#19 0x7f0d225c0f8c base::MessageLoop::DoWork()
#20 0x7f0d225c3379 base::MessagePumpLibevent::Run()
#21 0x7f0d225c02b9 base::MessageLoop::Run()
#22 0x7f0d225f70a9 base::RunLoop::Run()
#23 0x000002c34726 content::MessageLoopRunner::Run()
#24 0x000002c34c65 content::WindowedNotificationObserver::Wait()
#25 0x0000017694b5 policy::LoginPolicyTestBase::SkipToLoginScreen()
#26 0x000001767c62 policy::ForceMaximizeOnFirstRunTest_PRE_TwoRuns_Test::RunTestOnMainThread()
#27 0x000002bfbad2 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#28 0x000002707910 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#29 0x0000027067aa ChromeBrowserMainParts::PreMainMessageLoopRun()
#30 0x000002261cea chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#31 0x7f0d1e524c51 content::BrowserMainLoop::PreMainMessageLoopRun()
#32 0x7f0d1e9860e5 content::StartupTaskRunner::RunAllTasksNow()
#33 0x7f0d1e523609 content::BrowserMainLoop::CreateStartupTasks()
#34 0x7f0d1e527873 content::BrowserMainRunnerImpl::Initialize()
#35 0x7f0d1e521082 content::BrowserMain()
#36 0x7f0d1ef1363e content::ContentMainRunnerImpl::Run()
#37 0x7f0d1caf6024 service_manager::Main()
#38 0x7f0d1ef11c64 content::ContentMain()
#39 0x000002bfb65f content::BrowserTestBase::SetUp()
#40 0x0000026c3edf InProcessBrowserTest::SetUp()
#41 0x0000016e9921 chromeos::OobeBaseTest::SetUp()
#42 0x0000017691d5 policy::LoginPolicyTestBase::SetUp()
#43 0x000001b80261 testing::Test::Run()
#44 0x000001b80e30 testing::TestInfo::Run()
#45 0x000001b81317 testing::TestCase::Run()
#46 0x000001b8c427 testing::internal::UnitTestImpl::RunAllTests()
#47 0x000001b8bfae testing::UnitTest::Run()
#48 0x0000026d3f02 base::TestSuite::Run()
#49 0x00000267c945 ChromeTestSuiteRunner::RunTestSuite()
#50 0x000002c302c8 content::LaunchTests()
#51 0x00000267ce04 LaunchChromeTests()
#52 0x00000267c8de main
#53 0x7f0d1542f2b1 __libc_start_main
#54 0x0000007e836a _start

Project Member

Comment 5 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e0a57ab97729619e72ded6bf7ed8a304d5b1607

commit 5e0a57ab97729619e72ded6bf7ed8a304d5b1607
Author: kylechar <kylechar@chromium.org>
Date: Fri May 18 18:05:31 2018

viz: Re-enable passing viz_browser_tests.

Whatever the root cause of the failures was seems to be fixed. Enable
the tests again.

TBR: jonross@chromium.org
Bug:  796575 
Change-Id: Ib44d3ec502c42759c8e913d6b31a8e3bb3f2748c
Reviewed-on: https://chromium-review.googlesource.com/1066294
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559955}
[modify] https://crrev.com/5e0a57ab97729619e72ded6bf7ed8a304d5b1607/testing/buildbot/filters/viz.browser_tests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment