This feature request includes: 1. Remove the verifying rules for VPD data from the HWID framework. 2. Use a better way to get the VPD data if some rules need values in VPD.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/68a0e0da96a24c160f65c180e721e8592f290b44 commit 68a0e0da96a24c160f65c180e721e8592f290b44 Author: Yong Hong <yhong@chromium.org> Date: Fri Dec 29 14:45:38 2017 hwid: Moves the VPD value check into `gooftool verify_vpd` sub-command. This CL modifies `gooftool verify_vpd` sub-command so that it verifies not only values of RO VPD but also values of RW VPD. This CL also removes the default validation rules for VPD values from the HWID framework to prevent non-related and duplicated rules to be evaluated when the HWID framework is generating the HWID string. And since in general case VPD data is not required when the HWID framework is generating/verifying the HWID string, this CL also makes the HWID framework default not to obtain the VPD data, the caller should explicitly ask the HWID framework to obtain the VPD data if necessary. BUG= chromium:796556 TEST=make test Change-Id: I8f27127415307dda8d05d99b1c4e50cc1a589345 [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/test/test_lists/generic_common.test_list.json [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/gooftool/gooftool_unittest.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/hwid/v3/hwid_rule_functions.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/hwid/v3/valid_hwid_db_unittest.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/gooftool/core.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/probe/volatile_statement.json [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/gooftool/commands.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/hwid/v3/hwid_utils.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/test/pytests/hwid_v3.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/test/pytests/finalize.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/hwid/v3/hwid_cmdline.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/hwid/v3/builder.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/hwid/v3/common.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/hwid/v3/hwid_utils_unittest.py [modify] https://crrev.com/68a0e0da96a24c160f65c180e721e8592f290b44/py/test/test_lists/generic_grt.test_list.json
Comment 1 by yhong@chromium.org
, Dec 20 2017