New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796547 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 796326
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

wasm failing on chromium.perf/Android Nexus6 WebView Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 20 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of oysteine@google.com

wasm failing on chromium.perf/Android Nexus6 WebView Perf

Builders failed on: 
- Android Nexus6 WebView Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf


 
Specifically wasm/WasmTanks; disabling and starting bisect.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af0c93961bfb53a33cbe96d2c0432a309b82a876

commit af0c93961bfb53a33cbe96d2c0432a309b82a876
Author: Oystein Eftevaag <oysteine@chromium.org>
Date: Wed Dec 20 14:58:35 2017

Disabling wasm/WasmTanks benchmark on webview due to crashes

CC=aseemgarg@chromium.org
NOTRY=true
TBR=nednguyen@chromium.org
BUG= 796547 

Change-Id: I96d814ed8c23d539cb17b448521c4a009d22a275
Reviewed-on: https://chromium-review.googlesource.com/836598
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525328}
[modify] https://crrev.com/af0c93961bfb53a33cbe96d2c0432a309b82a876/tools/perf/expectations.config

Cc: nednguyen@chromium.org
Owner: rnep...@chromium.org
rnephew: Is [ Android ] not disabling the old ANDROID_WEBVIEW? It looks like this got re-enabled accidentally in the expectations move.




Or rather does the old ALL_ANDROID not map 100% to [ Android ] i.e. latter does not include webview?
Cc: charliea@chromium.org
Components: Speed>Telemetry
Owner: charliea@chromium.org
Status: Assigned (was: Available)
Randy's last day on the team was Monday, so I'll look into this.
Mergedinto: 796326
Status: Duplicate (was: Assigned)
Ah, sorry, this is a duplicate of a bug that I fixed yesterday. The problem isn't that ANDROID_WEBVIEW doesn't match ANDROID, but rather that disables without an associated reason (i.e. without a corresponding crbug.com/XXXXXX) weren't having any effect. This was fixed in https://chromium.googlesource.com/catapult.git/+/75149e9ea2a082634a59412eade1f15c87688a0d, which was rolled into chromium in 052657b6e6645941c9b39f2749d9c17986b5c96f and is in the current build. I'm going to go ahead and revert the extra disable you added, as it shouldn't be necessary after this build.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8810b5f2950fd505a6916b91e6812792f05bd392

commit 8810b5f2950fd505a6916b91e6812792f05bd392
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Dec 20 15:50:16 2017

Revert "Disabling wasm/WasmTanks benchmark on webview due to crashes"

This reverts commit af0c93961bfb53a33cbe96d2c0432a309b82a876.

The underlying problem was that disables without an associated reason
weren't having any effect. I already had a fix for this in the most
recent build, so this additional disable shouldn't be necessary.

TBR=oysteine@chromium.org, aseemgarg@chromium.org, nednguyen@google.com
NOTRY=true

Bug:  796547 
Change-Id: Idfc6e3b90619d54630125753ea76abb2dfa939ee
Reviewed-on: https://chromium-review.googlesource.com/836948
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525335}
[modify] https://crrev.com/8810b5f2950fd505a6916b91e6812792f05bd392/tools/perf/expectations.config

Comment 9 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 10 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment