Hitting DCHECK after signing into Chrome |
||||
Issue descriptionI hit this on today's ToT. Stacktrace: [184915:184955:1220/130646.159804:FATAL:shared_resources_data_source.cc(109)] Check failed: -1 != idr (-1 vs. -1) path: polymer/v1_0/iron-icons/iron-icon.html #0 0x7f2456e1e7dd base::debug::StackTrace::StackTrace() #1 0x7f2456e1cc1c base::debug::StackTrace::StackTrace() #2 0x7f2456ea3c0a logging::LogMessage::~LogMessage() #3 0x7f2451c1a183 content::SharedResourcesDataSource::StartDataRequest() #4 0x7f2451c26fba content::URLDataManagerBackend::StartRequest() #5 0x7f2451c21b7b content::URLRequestChromeJob::StartAsync() #6 0x7f244fdd243f _ZN4base8internal13FunctorTraitsIMN7content9URLLoaderEFvvEvE6InvokeINS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_ #7 0x7f244fdd23ba _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN7content9URLLoaderEFvvENS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ #8 0x7f244fdd2350 _ZN4base8internal7InvokerINS0_9BindStateIMN7content9URLLoaderEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #9 0x7f244fdd22f9 _ZN4base8internal7InvokerINS0_9BindStateIMN7content9URLLoaderEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #10 0x7f2456dc8f41 _ZNO4base12OnceCallbackIFvvEE3RunEv #11 0x7f2456e22f8a base::debug::TaskAnnotator::RunTask() #12 0x7f2456ebfff9 base::internal::IncomingTaskQueue::RunTask() #13 0x7f2456ec8dbe base::MessageLoop::RunTask() #14 0x7f2456ec9058 base::MessageLoop::DeferOrRunPendingTask() #15 0x7f2456ec93a0 base::MessageLoop::DoWork() #16 0x7f2456ecf059 base::MessagePumpLibevent::Run() #17 0x7f2456ec8552 base::MessageLoop::Run() #18 0x7f2456f78480 base::RunLoop::Run() #19 0x7f24570393a8 base::Thread::Run() #20 0x7f2450ee35a6 content::BrowserThreadImpl::IOThreadRun() #21 0x7f2450ee389f content::BrowserThreadImpl::Run() #22 0x7f2457039f83 base::Thread::ThreadMain() #23 0x7f245701fd51 base::(anonymous namespace)::ThreadFunc() #24 0x7f245736c494 start_thread #25 0x7f243d4b9a8f clone
,
Dec 20 2017
Note that the path contains /iron-icons/ while the resource map has /iron-icon/ (note the missing s) Searching for that leads to sync_confoirmation_app.html: https://cs.chromium.org/chromium/src/chrome/browser/resources/signin/dice_sync_confirmation/sync_confirmation_app.html?rcl=aafc53d5521fee77ac267db150b833a87d057146&l=4 which is Scott's, so assigning to Scott Chen. Can we add a browser test for each dialog that just brings them on screen, to avoid these kinds of issues?
,
Dec 20 2017
Ah, good catch. I think the problem is not the missing "s", but the extra "s" in the path. Assuming that the intention was to reference the existing iron-icon.html at [1]. > Can we add a browser test for each dialog that just brings them on screen, to avoid these kinds of issues? Sounds reasonable to me. Having said that, there could be other things to catch such errors earlier. Just mentioning one such example: If that particular dialog was respecting optimize_webui GN flag and used polymer-bundler, the compilation would fail when encountering the non-existing file. [1] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/iron-icon/iron-icon.html
,
Dec 21 2017
,
Dec 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7e1e91b04ccaccb1c73c05cbb2c290bc3926ce5 commit f7e1e91b04ccaccb1c73c05cbb2c290bc3926ce5 Author: Scott Chen <scottchen@chromium.org> Date: Fri Dec 29 02:48:31 2017 [signin] fix iron-icon path in sync confirmation dialog. Bug: 796536 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icdd1b45f3c87ef18a7ece9f361788c2011746f35 Reviewed-on: https://chromium-review.googlesource.com/837590 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#526353} [modify] https://crrev.com/f7e1e91b04ccaccb1c73c05cbb2c290bc3926ce5/chrome/browser/resources/signin/dice_sync_confirmation/sync_confirmation_app.html [modify] https://crrev.com/f7e1e91b04ccaccb1c73c05cbb2c290bc3926ce5/chrome/test/BUILD.gn [modify] https://crrev.com/f7e1e91b04ccaccb1c73c05cbb2c290bc3926ce5/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/f7e1e91b04ccaccb1c73c05cbb2c290bc3926ce5/chrome/test/data/webui/signin/signin_browsertest.js [add] https://crrev.com/f7e1e91b04ccaccb1c73c05cbb2c290bc3926ce5/chrome/test/data/webui/signin/sync_confirmation_test.js [add] https://crrev.com/f7e1e91b04ccaccb1c73c05cbb2c290bc3926ce5/chrome/test/data/webui/signin_browsertest.cc [add] https://crrev.com/f7e1e91b04ccaccb1c73c05cbb2c290bc3926ce5/chrome/test/data/webui/signin_browsertest.h
,
Jan 2 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Dec 20 2017