New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796535 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[Sync] Make USS ModelTypeStore more type-safe

Project Member Reported by mastiz@chromium.org, Dec 20 2017

Issue description

While reading the code around ModelTypeStore, it was confusing how values (protos) are passed around in string form, without type safety.

I'm wondering if we could rename ModelTypeStore to ModelTypeStoreBase, and add a templatized thin layer on top that provides type safety, and removes boilerplate from callers (parsing and serialization), at the same time making the code less error-prone.
 

Comment 1 by gangwu@chromium.org, Jan 17 2018

Labels: SyncHandoff2018

Comment 2 by mastiz@chromium.org, Jan 17 (6 days ago)

Summary: [Sync] Make USS ModelTypeStore more type-safe (was: [Sync] Make USS ModelTypeStore mode type-safe)

Sign in to add a comment