New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796517 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 799835
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Use consistent URL eliding for desktop PWAs

Project Member Reported by owencm@google.com, Dec 20 2017

Issue description

Chrome Version       : 64.0.3282.24

We're inconsistent about URL eliding in Desktop PWAs today.

e.g. In the "Add to shelf" dialog the URL is shown as "www.progressivewebflap.com", but once installed the title bar says "by progressivewebflap.com"

Can we be consistent about which URL eliding we're using so these match?
 

Comment 1 by owe...@chromium.org, Dec 20 2017

Cc: dominickn@chromium.org
Labels: Needs-Triage-M64
Cc: calamity@chromium.org mgiuca@chromium.org
Labels: -Needs-Triage-M64 OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Unconfirmed)
Summary: Use consistent URL eliding for desktop PWAs (was: Use consistent URL eliding)
progressivewebflap.com isn't an origin, it's a hostname. That title probably should use an origin (and should use the same elision method in the add to shelf dialog).
ETLD+1 was chosen as a compromise between the security of an origin, the branding of a hostname, and the (relative) brevity needed to comfortably fit in a titlebar.

To me, in the app title, we are using the ETLD+1 to describe an organisation, which makes sense.

Spotify by spotify.com rolls off the tongue better than Spotify by play.spotify.com, or Docs by docs.google.com.

I'm guessing that we show the origin (minus scheme) as a security affordance on the add to shelf dialog, so these two things serve different purposes.

If we really want consistency here, I'd prefer using the ETLD+1 in the add to shelf dialog since the app title will be shown more prominently and we want that to be as user-friendly as possible.
We have to show the origin in one of the add to shelf dialog or the title bar so that the user can associate the origin (security boundary) with the app title and app icon.

If we want this to be consistent, it needs to be the origin in the title bar, since we can't just show ETLD+1 in both places.
If we end up removing the app name in the title, can we just show the origin in the title bar?

Comment 7 by owe...@chromium.org, Dec 30 2017

Huh, thanks for the explanation Dom!

I think it's fine for these to be inconsistent now I understand a bit more (although of course consistent would have been a nice touch) - I suppose in the specific case I filed the bug for I was hoping we would have already elided "www" in accordance with long term plans to elide "m." and "www.", so I feel OK about these being different so long as the common "www." case will be fixed at some point in the future as part of the more general eliding of syntaxy origins.
Mergedinto: 799835
Status: Duplicate (was: Available)

Sign in to add a comment