Non-Regression:Unwanted line is seen in Gallery |
|||||||||||
Issue descriptionChrome Version:64.0.3282.41/10176.22.0 beta-channel Daisy,Reks,Kip OS:chrome OS What steps will reproduce the problem? (1)Sign into user -> Take a sample screenshot ->Open with Gallery and Delete it (2)Hover the mouse near header of ' No images in this directory' screen and Observe(Please refer video) Actual: Unwanted line is seen at top-left corner Expected:No such line should be seen This is a Non-Regression issue seen from M-55. Note: 1.Issue is also seen in M-65 2.Issue is not seen in Windows,Linux OS
,
Dec 21 2017
,
Jun 7 2018
Issue 825151 has been merged into this issue.
,
Jun 7 2018
,
Sep 7
I think I have a fix for this ready
,
Sep 7
Here are my changes: https://chromium-review.googlesource.com/c/chromium/src/+/1212263
,
Sep 25
Assigning the bug to you. Feel free to unassign if you stop working on it. Once more thanks for working on it.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d270ec3902afe58988234832b7c33f7e5ce92aa6 commit d270ec3902afe58988234832b7c33f7e5ce92aa6 Author: Alexander Nohe <nohe@chromium.org> Date: Fri Oct 05 02:59:50 2018 Hide filename edit field when there is no image Hide |filenameEdit_| line edit box when there is no image to be displayed. This fixes an undesired grey line appearing as the bottom of this edit box. Changing the "disabled" state doesn't change the style of this box, "disabled" state is only used for read-only behaviour not style. R=fukino@chromium.org Bug: 796503 Change-Id: I6fc9a4eb218231781325ba7a5af992b12610b929 Reviewed-on: https://chromium-review.googlesource.com/c/1212263 Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alexander Nohe <nohe@chromium.org> Cr-Commit-Position: refs/heads/master@{#596972} [modify] https://crrev.com/d270ec3902afe58988234832b7c33f7e5ce92aa6/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/d270ec3902afe58988234832b7c33f7e5ce92aa6/ui/file_manager/gallery/js/gallery.js [modify] https://crrev.com/d270ec3902afe58988234832b7c33f7e5ce92aa6/ui/file_manager/integration_tests/gallery/open_image_files.js [modify] https://crrev.com/d270ec3902afe58988234832b7c33f7e5ce92aa6/ui/file_manager/integration_tests/gallery/thumbnail_mode.js
,
Oct 5
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b7961c27546973db0292d9d3d373a1d19eb2aa9 commit 9b7961c27546973db0292d9d3d373a1d19eb2aa9 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Oct 05 08:18:01 2018 Revert "Hide filename edit field when there is no image" This reverts commit d270ec3902afe58988234832b7c33f7e5ce92aa6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596972 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDI3MGVjMzkwMmFmZTU4OTg4MjM0ODMyYjdjMzNmN2U1Y2U5MmFhNgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8178 Sample Failed Step: viz_browser_tests Sample Flaky Test: GalleryBrowserTest.DeleteSingleOpenPhotoOnDownloads Original change's description: > Hide filename edit field when there is no image > > Hide |filenameEdit_| line edit box when there is no image to be displayed. > This fixes an undesired grey line appearing as the bottom of this edit box. > Changing the "disabled" state doesn't change the style of this box, > "disabled" state is only used for read-only behaviour not style. > > R=fukino@chromium.org > > Bug: 796503 > Change-Id: I6fc9a4eb218231781325ba7a5af992b12610b929 > Reviewed-on: https://chromium-review.googlesource.com/c/1212263 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Alexander Nohe <nohe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596972} Change-Id: I5a64c57351cc39d641af6052567c8f8d150542cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 796503 , 892543 Reviewed-on: https://chromium-review.googlesource.com/c/1263887 Cr-Commit-Position: refs/heads/master@{#597033} [modify] https://crrev.com/9b7961c27546973db0292d9d3d373a1d19eb2aa9/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/9b7961c27546973db0292d9d3d373a1d19eb2aa9/ui/file_manager/gallery/js/gallery.js [modify] https://crrev.com/9b7961c27546973db0292d9d3d373a1d19eb2aa9/ui/file_manager/integration_tests/gallery/open_image_files.js [modify] https://crrev.com/9b7961c27546973db0292d9d3d373a1d19eb2aa9/ui/file_manager/integration_tests/gallery/thumbnail_mode.js
,
Oct 5
This was reverted due to test being flaky. Resuming work on this.
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e353acb08137c333da51aa1535aa3f75d581fb3 commit 6e353acb08137c333da51aa1535aa3f75d581fb3 Author: Alexander Nohe <nohe@chromium.org> Date: Mon Oct 08 23:21:08 2018 Hide filename edit field when there is no image Hide |filenameEdit_| line edit box when there is no image to be displayed. This fixes an undesired grey line appearing at the bottom of this edit box. Changing the "disabled" state doesn't change the style of this box, "disabled" state is only used for read-only behavior not style. R=lucmult@chromium.org, noel@chromium.org Bug: 796503 Change-Id: I48991bf6d854ae6050f2e011067e6d3bf2c36619 Reviewed-on: https://chromium-review.googlesource.com/c/1265032 Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alexander Nohe <nohe@chromium.org> Cr-Commit-Position: refs/heads/master@{#597724} [modify] https://crrev.com/6e353acb08137c333da51aa1535aa3f75d581fb3/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/6e353acb08137c333da51aa1535aa3f75d581fb3/ui/file_manager/gallery/js/gallery.js [modify] https://crrev.com/6e353acb08137c333da51aa1535aa3f75d581fb3/ui/file_manager/integration_tests/gallery/open_image_files.js [modify] https://crrev.com/6e353acb08137c333da51aa1535aa3f75d581fb3/ui/file_manager/integration_tests/gallery/thumbnail_mode.js
,
Oct 9
,
Oct 12
,
Oct 12
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16
Has the new attempt from #12 verified as working as anticipated and not flakey?
,
Oct 16
Yes, this is also showing up in Chrome Canary. is it possible its already been merged?
,
Oct 17
Canary doesn't need to be merged.. It's picking up from ToT. You only need to merge post-branch. To be clear, are you saying the problem is resolved when you check on it in canary?
,
Oct 17
Correct. I may have requested a merge in error.
,
Oct 18
Removing merge request per #19
,
Oct 31
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by rkalavakuntla@chromium.org
, Dec 20 2017Summary: Non-Regression:Unwanted line is seen in Gallery (was: Regression:Unwanted line is seen in Gallery )