New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 796501 link

Starred by 3 users
Status: Verified
Owner:
fukino@chromium.org
Closed: Jan 2018
Cc:
ajha@chromium.org
█ oka@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary 'Download' option is available in General information page and on clicking 'Download' icon nothing happens

Project Member Reported by mmanchala@chromium.org, Dec 20 2017 
Chrome Version: 64.0.3282.39/10176.21.0 Beta-channel Kip,Daisy,Reks
OS: Chrome

Sample URL : http://www.sample-videos.com/

What steps will reproduce the problem?
(1)Sign in to user ->Now go to above URL -> download any file
(2)Now go to Files App  -> Select downloaded video -> Right Click and select 'Get info' option or click on 'Space' Key
(3)After clicking on 'Get info' option or on 'Space' Key Video will start playing in General information page -> Now Observe unnecessary 'Download' option is available and on clicking  'Download' icon nothing happens  (Please refer video)


Expected: Unnecessary 'Download' option should not be seen in General information page  as video is already downloaded in Files App
Actual: Instead  unnecessary 'Download' option is available and on clicking  'Download' icon nothing happens 

This is Regression Issue seen as same is working fine in M-63

@fukinoo : Please confirm the Issue

Note : Issue is also seen on latest M-65
Actual_UnnecessarydDownloadOption.webm
1.9 MB View Download
Actual_UnnecessarydDownloadOption.png
839 KB View Download
Expecte_NoDownloadOption.webm
2.1 MB View Download
Expecte_NoDownloadOption.jpg
190 KB View Download

Comment 1 by kbleicher@google.com, Dec 20 2017

Labels: -M-65 M-64
This was discovered in M64, not M65, so modifying label to reflect.   Also, not sure if this is really a blocker but will keep the stable label for evaluation

Comment 2 by kbleicher@chromium.org, Jan 2 2018

Labels: -ReleaseBlock-Stable
Doesn't seem like a blocker.  Quite the edge case.  Removing label.  Please re-add if there's a more compelling reason to block.  Thx
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b851f7e531056dfc4931b6402c640f9b540168f

commit 3b851f7e531056dfc4931b6402c640f9b540168f
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Jan 16 11:58:59 2018

Files app: Disable download option for video previw in quick view.

Now <video> tag provides download option by default.
We need to explicitly disable it by adding an attribute to the video tag.
https://developers.google.com/web/updates/2017/03/chrome-58-media-updates#controlslist

Bug:  796501 
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib7b83ea442e76b46697e9e9b758d5a90e685d37e
Reviewed-on: https://chromium-review.googlesource.com/867805
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529403}
[modify] https://crrev.com/3b851f7e531056dfc4931b6402c640f9b540168f/ui/file_manager/file_manager/foreground/elements/files_safe_video_webview_content.html

Comment 4 by fukino@chromium.org, Jan 17 2018

Status: Fixed (was: Assigned)

Comment 5 by mkarkada@chromium.org, Jan 26 2018

Status: Verified (was: Fixed)
Verified on M65- 10323.4.0, 65.0.3325.16 dev build.
►

Sign in to add a comment