New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796498 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Entered password is not selected when Tab focus is on 'Password' field in Lock Screen

Project Member Reported by mmanchala@chromium.org, Dec 20 2017

Issue description

Chrome Version: 64.0.3282.39/10176.21.0 Beta-channel Kip,Daisy,Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> click on Uber Tray and select 'Lock' option
(2)In Lock screen enter password in 'Password' field -> now press 'Tab' button until focus is seen on 'Password' field 
(3)Now observe entered password is not selected (Please refer Video)

Expected: Entered password should get selected when Tab focus is on 'Password' field 
Actual: Instead only cursor is seen in 'Password' field 

This is Regression Issue as same is working fine in 63.0.3239.86/10032.71.1  Candy

@wzang: Please confirm the issue

Note : Issue is also seen on latest M-65
 
Actual_TabFocusOnPasswordField.mp4
12.4 MB View Download
Actual_TabFocusOnPasswordField.jpg
736 KB View Download
Attaching Expected video for reference
Expected_TabFocusOnPasswordField.mp4
8.9 MB View Download
Expected_TabFocusOnPasswordField.jpg
503 KB View Download

Comment 2 by wzang@chromium.org, Dec 20 2017

Cc: jdufault@chromium.org
Cc: wzang@chromium.org
Owner: jdufault@chromium.org
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/837183
Cc: -jdufault@chromium.org r...@chromium.org
Labels: -M-65 M-64
This was discovered in M64, not M65, so modifying label to reflect.   Also, not sure if this is really a blocker but will keep the stable label for evaluation

Updating labels to block stable so we can re-evaluate.
Disregard last comment in #5; was already marked as stable.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e2a64023971e46672e89783154a71afede684cb

commit 9e2a64023971e46672e89783154a71afede684cb
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Dec 22 06:36:18 2017

cros: Select all text on login password textfield focus.

Bug:  796498 
Change-Id: I50eaf6cf5e65e3b5677d1f37002da063022a3a7a
Reviewed-on: https://chromium-review.googlesource.com/837183
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525946}
[modify] https://crrev.com/9e2a64023971e46672e89783154a71afede684cb/ash/login/ui/login_password_view.cc

Confirmed as fixed?
And per #8, if so, assume this will be a merge request or removed as a blocker (doen't seem like a blocking issue)
Labels: -ReleaseBlock-Stable
Status: Fixed (was: Started)
Removing RBS
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment