New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796489 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Attempting to open two (native) color inputs from separate windows stops second color input from working

Reported by brettd3...@gmail.com, Dec 20 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36

Steps to reproduce the problem:
1. Open https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/color in two separate windows.
2. Open color input in first window.
3. Attempt to open the color input in the second window.
4. Close first color input.
5. Attempt to open color input in second window.

What is the expected behavior?
After closing the first color input, the second window should be able to open a color input.

What went wrong?
The color input in the second window does not open.

Did this work before? No 

Chrome version: 63.0.3239.84  Channel: stable
OS Version: 10.0
Flash Version:
 
Labels: Needs-Triage-M63
Unable to reproduce the issue on reported chrome version 63.0.3239.84 and latest canary 65.0.3306.0 using windows-10 with steps mentioned below

Steps followed to reproduce the issue:
1) Launched chrome reported version
2) Open the URL: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/color in two new windows
3) On the first window opened Color input and also in second window opened color input
4) Closed color input in first window and navigated to second window and opened color input
5) Able to open color input on second window

@Reporter:
Please find the attached screen cast for you reference and let us know if we have missed anything in reproducing the issue, try to test the issue by creating new person with no extensions and apps in it and le us know if the issue still persists.

Thanks!
796489.mp4
5.0 MB View Download
Cc: viswatej...@techmahindra.com sc00335...@techmahindra.com
Labels: Needs-Feedback Triaged-ET
Sorry, my original explanation wasn't clear enough. I mean open the color dialog, by clicking on the input element itself.

Steps 2-5 are better explained:
2. Open color dialog box by clicking on color input.
3. Attempt to open the color dialog box in the second window.
4. Close first color dialog box.
5. Attempt to open color dialog box in second window.


The issue happens with the native windows color dialog box not being opened when clicking on the color input in the second window.
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 3 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug -Pri-2 Needs-Bisect Pri-1 Type-Bug-Regression
Components: Blink>Internals>Modularization
Labels: -Needs-Bisect ReleaseBlock-Stable M-65 hasbisect
Owner: joelhockey@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Win-10 using chrome latest stable #63.0.3239.132 but the same is not reproducible in the latest canary #65.0.3324.0.
Issue is not seen on OS-Mac and OS-Linux.

Reverse Bisect Information:
=====================
Good build: 65.0.3293.0
Bad Build : 65.0.3291.0

Note: Unable to provide per revision bisect results as when chrome is getting invoked, a black screen is rendered. The chrome version #65.0.3292.0 upon installing shows black screen. Hence, providing manual bisect and providing Cl from omahaproxy.

Change Log URL: (from Omahaproxy)
https://chromium.googlesource.com/chromium/src/+log/65.0.3291.0..65.0.3293.0?pretty=fuller&n=10000

From the above change log suspecting below change
Change-Id: I436e277738bf0e37eda8bfa0fd7428aede015c43
Reviewed-on: https://chromium-review.googlesource.com/800350

joelhockey@ - Could you please check and merge the fix to M-65 if it is a valid candidate.
Adding label RBS as it seems to be a recent regression. Please feel free to remove the same if not appropriate.
Thanks...!!
Labels: -M-65 M-64 FoundIn-64 Target-64 FoundIn-63
Labels: -ReleaseBlock-Stable
Owner: jsb...@chromium.org
Please ignore the comment #7

Able to reproduce the issue on Win-10 using chrome latest stable #63.0.3239.132 but the same is not reproducible in the latest canary #65.0.3324.0.
Issue is not seen on OS-Mac and OS-Linux.

Reverse Bisect Information:
=====================
Good build: 65.0.3293.0
Bad Build : 65.0.3291.0

Note: Unable to provide per revision bisect results as when chrome is getting invoked, a black screen is rendered. The chrome version #65.0.3292.0 upon installing shows black screen. Hence, providing manual bisect and providing Cl from omahaproxy.

Change Log URL: (from Omahaproxy)
https://chromium.googlesource.com/chromium/src/+log/65.0.3291.0..65.0.3293.0?pretty=fuller&n=10000

From the above change log suspecting below change
Change-Id: Ia327a7a9f92c34fd3fcdf971d8c21a5ce744254b
Reviewed-on: https://chromium-review.googlesource.com/814916

jsbell@ - Could you please check and merge the fix to M-64 if it is a valid candidate.

Thanks...!!

Cc: joelhockey@chromium.org
Owner: krajshree@chromium.org
My change is scoped to <input type=file webkitdirectory> and only affects keyboard handling (not clicks), and was not a fix in this sense, i.e. it was new behavior introduced for other reasons, not to fix a bug like this.

joelhockey@'s 
https://chromium.googlesource.com/chromium/src/+/85b379dae71f793833f3e57bdbde5cc62dbc121b change is a much more likely candidate in the range. That's also some architectural rework rather than a merge-able fix, though. No idea if that's how this started working again, but a better place to start.




I did make a fairly recent change to convert ColorChooser from ipc to mojo.  At the time, I recall doing a manual test of this sort of thing on linux, but I did not test on windows.

If I understand the comments so far, it appears that the work I did may have _fixed_ a bug rather than _caused_ a bug.

I can't think of any reason why my CL could not be merged into an older branch.  Unfortunately, my team has been taken off chromium, so I don't have much time to help here.

Sign in to add a comment