Goofy re-runs already passed test. |
|||||
Issue descriptionFactory Repo: b10be04d4690806b6ec03e9a90e621c4e44a3eb8 Steps to reproduce: 1. Switch to the attached test list "orz.test_list.json" 2. Pass TestGroup SMT.SMTComponents 3. Stop Goofy when testing TestGroup SMT.SMTStress 4. Click the Goofy "play" button, which is between language toggle button and web terminal button. 5. Goofy re-runs the already passed TestGroup SMT.SMTComponents. It seems like if a TestGroup contains skipped test items might encounter this issue.
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/9892a42dd5c4d4a8d43447e4abeae3bb0dcebdd7 commit 9892a42dd5c4d4a8d43447e4abeae3bb0dcebdd7 Author: Wei-Han Chen <stimim@google.com> Date: Thu Dec 21 02:03:40 2017 test list iterator: fix CheckSkip for parallel group When a group is parallel, it will be considered 'IsRunnableTest'. However, when we are checking if we need to rerun a test that was 'SKIPPED', the rule should be: * For test groups, they need retest if their run_if are set, and evaluate to True. * For **leaf tests**, they need retest if their run_if are not set, or evaluate to True. Because a **runnable test** might be a test group. BUG= chromium:796485 TEST=make test Change-Id: I8b77ad5957374b1632882deacd47241e3e836318 Reviewed-on: https://chromium-review.googlesource.com/838580 Reviewed-by: Youcheng Syu <youcheng@chromium.org> Commit-Queue: Youcheng Syu <youcheng@chromium.org> Tested-by: Youcheng Syu <youcheng@chromium.org> Trybot-Ready: Youcheng Syu <youcheng@chromium.org> [modify] https://crrev.com/9892a42dd5c4d4a8d43447e4abeae3bb0dcebdd7/py/goofy/test_list_iterator_unittest.py [modify] https://crrev.com/9892a42dd5c4d4a8d43447e4abeae3bb0dcebdd7/py/goofy/test_list_iterator.py
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/a440327e29db0527c391ddab568ff81c867073c8 commit a440327e29db0527c391ddab568ff81c867073c8 Author: Wei-Han Chen <stimim@google.com> Date: Thu Dec 21 02:36:34 2017 test list iterator: fix CheckSkip for parallel group When a group is parallel, it will be considered 'IsRunnableTest'. However, when we are checking if we need to rerun a test that was 'SKIPPED', the rule should be: * For test groups, they need retest if their run_if are set, and evaluate to True. * For **leaf tests**, they need retest if their run_if are not set, or evaluate to True. Because a **runnable test** might be a test group. BUG= chromium:796485 TEST=make test Change-Id: I8b77ad5957374b1632882deacd47241e3e836318 Reviewed-on: https://chromium-review.googlesource.com/838720 Reviewed-by: Yilun Lin <yllin@chromium.org> Commit-Queue: Yilun Lin <yllin@chromium.org> Tested-by: Yilun Lin <yllin@chromium.org> [modify] https://crrev.com/a440327e29db0527c391ddab568ff81c867073c8/py/goofy/test_list_iterator_unittest.py [modify] https://crrev.com/a440327e29db0527c391ddab568ff81c867073c8/py/goofy/test_list_iterator.py
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/b14bba2c25ffed3b1373dd7c2ff2f5f5fa7ad26c commit b14bba2c25ffed3b1373dd7c2ff2f5f5fa7ad26c Author: Wei-Han Chen <stimim@google.com> Date: Thu Dec 21 07:01:55 2017 test list iterator: fix CheckSkip for parallel group When a group is parallel, it will be considered 'IsRunnableTest'. However, when we are checking if we need to rerun a test that was 'SKIPPED', the rule should be: * For test groups, they need retest if their run_if are set, and evaluate to True. * For **leaf tests**, they need retest if their run_if are not set, or evaluate to True. Because a **runnable test** might be a test group. BUG= chromium:796485 TEST=make test Change-Id: I8b77ad5957374b1632882deacd47241e3e836318 [modify] https://crrev.com/b14bba2c25ffed3b1373dd7c2ff2f5f5fa7ad26c/py/goofy/test_list_iterator_unittest.py [modify] https://crrev.com/b14bba2c25ffed3b1373dd7c2ff2f5f5fa7ad26c/py/goofy/test_list_iterator.py
,
Dec 21 2017
,
Jul 30
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by youcheng@chromium.org
, Dec 20 2017