maxwalker@ srahim@ Could you please advise how to handle this issue?

I added a suggestion to the code review for the message descriptions, otherwise the strings LGTM.

srahim: to clarify do you think using "Sensors" as the short string is clear enough? The issue in my mind is that "Sensors" is such a vague word that encompasses so many possible things. I'm worried that people will open Site Details and have no idea what it is/means.

"Motion and light sensors" seems far more descriptive. Alternatively, perhaps we need to find away to introduce long descriptions into Site Details which might solve this problem in a more general way (see screenshot).

Deleted: sitesettings.png 56.6 KB

	sitesettings.png 56.6 KB View Download

raymes@ srahim@ I made a Google doc and shared it with you.

Attached a proposal for an icon to use in Page Info, Site Settings, omnibox and dialogs. WDYT?

Deleted: Sensors Icon.png 101 KB

	Sensors Icon.png 101 KB View Download

Hi Team,

Looking at the report, this is not a localization case. We will be looping in the Engineering Team for review.

Happy Holidays everyone!

Regards!

cc scheib, reillyg

Thanks Max! LGTM!

The mock in #5 lgtm

+srahim: are you ok with the string used here?

maxwalker@ Icon looks nice, thanks! What would be the way to proceed with https://chromium-review.googlesource.com/c/chromium/src/+/833924 ? I would need to add icon to the CL, so that UNSANDBOXED_PLUGINS icon is not used as a placeholder.

Could you attach resource to this bug?

Yes, of course. You can find the icon in the attachment. Please let me know if you need other sizes.

Deleted: ic_sensors_black_16dp.svg 2.0 KB

ic_sensors_black_16dp.svg 2.0 KB Download

Deleted: ic_sensors_black_20dp.svg 2.0 KB

ic_sensors_black_20dp.svg 2.0 KB Download

String "Motion or light sensors" LGTM, thanks.

maxwalker@ Could you please tell what icon size should be used for PageInfo dialog? I have 16dp and 20dp icons, should 18dp be used?

srahim@ I checked strings for PageInfo dialog and it looks like strings are camel cased. Should I use "Motion and Light Sensors" or "Motion and light sensors"?

Deleted: infobar_casing.png 59.3 KB

	infobar_casing.png 59.3 KB View Download

Re: #15 I think patricialor answered this in https://chromium-review.googlesource.com/c/chromium/src/+/836467#message-9dff2ea0676496fbe1aa50f5ac8aa12088a4b88c

Thanks for reaching out. The icons should be 16dp. You can find the full spec here: https://goo.gl/eCFDVk (Google internal link).

maxwalker@ I was trying to make png files for android build, yet, I'm facing some difficulties. Looks like png files are grayscale with special color table. If you have tools / export setting presets, could export svgs to png files of correct format?

I need following resolutions:

xxhdpi
xxxhdpi
mdpi
xhdpi
hdpi

Icons would be used in content settings ui https://bugs.chromium.org/p/chromium/issues/attachment?aid=321245&signed_aid=cvDnN5GKZo2d9aMCEkJNLA==&inline=1

maxwalker@ I found a way to optimize pngs, will generate resources myself.

maxwalker@ provided required resources. Issue can be closed.