New issue
Advanced search Search tips

Issue 796483 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task

Blocked on:
issue 753599



Sign in to add a comment

☂ Cleanup of Recent Tabs

Project Member Reported by gambard@chromium.org, Dec 20 2017

Issue description

Once the bookmarks are enabled, the Recent Tabs controller should have only one implementation (as it will only be presented modally).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40534c4b92496b9d331ff9b25eba69d779d60905

commit 40534c4b92496b9d331ff9b25eba69d779d60905
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Jan 19 16:49:23 2018

Recent Tabs cleanup after Bookmarks new gen

This CL cleans up the NTP-related part of the RecentTabs now that the
Bookmarks NewGen are enabled and that the RecentTabs cannot be presented
on the NTP.
It also cleans up the NTPPanelProtocol.

Bug:  796483 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4f18e9810479fb363e7fabce461bdcf0b508c925
Reviewed-on: https://chromium-review.googlesource.com/873211
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530538}
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/ntp/incognito_view_controller.mm
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/ntp/new_tab_page_panel_protocol.h
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.h
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.mm
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/40534c4b92496b9d331ff9b25eba69d779d60905/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm

Labels: -Type-Bug Type-Task
Status: Fixed (was: Assigned)

Sign in to add a comment