New issue
Advanced search Search tips

Issue 796468 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac: Replace calls to CGColorSpaceCreateWithName(kCGColorSpaceSRGB) with base::mac::GetSRGBColorSpace()

Project Member Reported by tapted@chromium.org, Dec 20 2017

Issue description

Chrome Version       : 65.0.3294.5
OS Version: OS X 10.12.6

I noticed one in ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

mac_util.mm has


CGColorSpaceRef GetSRGBColorSpace() {
  // Leaked.  That's OK, it's scoped to the lifetime of the application.
  static CGColorSpaceRef g_color_space_sRGB =
      CGColorSpaceCreateWithName(kCGColorSpaceSRGB);
  DLOG_IF(ERROR, !g_color_space_sRGB) << "Couldn't get the sRGB color space";
  return g_color_space_sRGB;
}


I dunno what the performance cost of CGColorSpaceCreateWithName, but if we have GetSRGBColorSpace() I guess we should use it /shruggie
 
Labels: Hotlist-DesktopUIChecked
Status: WontFix (was: Assigned)
***UI Mass Triage ***

Closing due to inactivity, feel free to reopen if needed.

Sign in to add a comment