New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796457 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
M65


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Enable window.resizeTo API on floating keyboard.

Project Member Reported by wuyingbing@chromium.org, Dec 20 2017

Issue description

When switches virtual keyboard to floating mode by API
chrome.virtualKeyboardPrivate.setMode('FLOATING')

Should resize the floating virtual keyboard by window.resizeTo API


 
Owner: wuyingbing@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f93ee4c34305aac44ce1e9f0b786ec6789bf8f8

commit 1f93ee4c34305aac44ce1e9f0b786ec6789bf8f8
Author: Yingbing Wu <wuyingbing@chromium.org>
Date: Tue Jan 09 07:01:44 2018

Removes floating keyboard width restriction. Enables window.resizeTo/resizeBy API on
floating keyboard.

Needn't restrict width/height minimal value for floating keyboard, because Chrome already
restricts window width/heigth minimal value to 100px. Chrome allow to set width/height to 0px
to hide the window.

BUG= chromium:796457 

Change-Id: I9de3f4cc299104a5fb77a61b3e4a39bbc61c6488
Reviewed-on: https://chromium-review.googlesource.com/846618
Commit-Queue: Yingbing Wu <wuyingbing@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527918}
[modify] https://crrev.com/1f93ee4c34305aac44ce1e9f0b786ec6789bf8f8/ui/keyboard/container_floating_behavior.cc

Status: Fixed (was: Started)

Sign in to add a comment