New issue
Advanced search Search tips

Issue 796456 link

Starred by 2 users
Status: Archived
Owner:
tetsui@chromium.org
Closed: Dec 2017
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Notifier settings animation speed is wrong when there are many notifiers

Project Member Reported by tetsui@chromium.org, Dec 20 2017 
Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Install many extensions (> 30) with notifiers.
(2) Open notification center from the right bottom.
(3) Open notifier settings by clicking the settings button.

What is the expected result?
Notifier settings shows up with the same velocity with an environment with a fewer notifiers (< 5).

What happens instead?
It animates faster.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81646ad835bc8d3d84038be8e63d1466c6212014

commit 81646ad835bc8d3d84038be8e63d1466c6212014
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Dec 21 04:45:23 2017

Fix notifier settings animation speed with many notifiers.

When there are many notifier sources, notifier settings animation speed
was wrong becuase it used view's PreferredSize as the target height,
but the maximum height is limited to the screen height.
As a result, the animation stopped when it reached the screen height.

TEST=manual
BUG= 796456 

Change-Id: I4cf7083b257d4f5519bc02a0d698509943d662cc
Reviewed-on: https://chromium-review.googlesource.com/835930
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525612}
[modify] https://crrev.com/81646ad835bc8d3d84038be8e63d1466c6212014/ash/message_center/message_center_bubble.cc
[modify] https://crrev.com/81646ad835bc8d3d84038be8e63d1466c6212014/ash/message_center/message_center_bubble.h
[modify] https://crrev.com/81646ad835bc8d3d84038be8e63d1466c6212014/ash/message_center/message_center_view.cc
[modify] https://crrev.com/81646ad835bc8d3d84038be8e63d1466c6212014/ash/message_center/message_center_view.h

Comment 2 by tetsui@chromium.org, Dec 21 2017

Status: Fixed (was: Started)

Comment 3 by dchan@google.com, Jul 30

Status: Archived (was: Fixed)
►

Sign in to add a comment