virtual/reporting suite not running on Windows bots |
||||
Issue description
I noticed today that the "reporting" virtual test suite seemed to never run on Windows bots. The suite is defined as:
{
"prefix": "reporting",
"base": "external/wpt/content-security-policy/reporting",
"args": ["--enable-features=Reporting"]
}
Example:
https://ci.chromium.org/buildbot/tryserver.blink/win10_blink_rel/5489
No "virtual/reporting/" can be found in the merged stdout of webkit_layout_tests or the result viewer. The linux and mac jobs of the same CL did include them (e.g. https://storage.googleapis.com/chromium-layout-test-archives/linux_trusty_blink_rel/20405/layout-test-results/results.html)j.
Is this intentional? (If yes, where is it configured?)
,
Jan 5 2018
I don't know, since I didn't set those up. I'm routing to mkwst for now, since I've worked with him on some of the Reporting-in-Blink stuff.
,
Jan 5 2018
Thanks, Julia. This is (probably) not urgent and has been like this for a while. Let's wait until mkwst comes back. The first question to ask is whether folks who set up the suite ever intended to skip the suite on Windows (I suspect not). Once we confirm that was not intentional, I will find some time to debug the test running infra.
,
Jan 8 2018
robertma@ - Indeed I never intended to skip Windows tests when setting up the suite and I don't know why it would.
,
Jan 8 2018
Handing back to robertma@, as we don't intend to skip the tests, the virtual test suite setup looks correct, and we don't appear to be skipping the tests in Blink's `TestExpectations`.
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e75ab315ccfb7e197f17fe489302a136a7a2f12 commit 1e75ab315ccfb7e197f17fe489302a136a7a2f12 Author: Chris Nardi <cnardi@chromium.org> Date: Fri Mar 09 18:27:30 2018 Fix running of entire WPT folders on Windows We assumed that the file separator would be dependent on the filesystem in the WPT manifest (so '\' on Windows), but the manifest always uses '/', no matter what the platform. Change this code to always split on '/'. This change also fixes a bug where WPT tests would not run under virtual test suites on Windows. Bug: 796424 Change-Id: Iea7466bc1208f9c8fd9938688c31029917944f77 Reviewed-on: https://chromium-review.googlesource.com/956662 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#542166} [modify] https://crrev.com/1e75ab315ccfb7e197f17fe489302a136a7a2f12/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/1e75ab315ccfb7e197f17fe489302a136a7a2f12/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
,
Mar 9 2018
Thank you for fixing this bug, Chris! |
||||
►
Sign in to add a comment |
||||
Comment 1 by mkwst@chromium.org
, Dec 20 2017Owner: juliatut...@chromium.org
Status: Assigned (was: Untriaged)