New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796388 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Redundant copies of PepperFlashPlayer in encrypted stateful partition

Project Member Reported by sarthakkukreti@chromium.org, Dec 19 2017

Issue description

Redundant copies of PepperFlashPlayer are currently stored in both /var/lib/imageloader/PepperFlashPlayer and /home/chronos/PepperFlash, which are bind mounts with source dir in /mnt/stateful_partition/encrypted. Each version occupies around 16M in disk space.

(context: reducing encrypted stateful partition footprint for migration: chromium:773590)
 
This is because imageloader mounts the version in its storage. Imageloader now has LoadComponentAtPath so we could skip the registration and copy (which saves space and makes installation easier), but that complicates loading PepperFlashPlayer at boot time. ImageLoader would have to know how to go looking in /home/chronos/PepperFlash for the current version and load that. I'm not sure it's worth the 16M saving, what do you think waffles@?
/home/chronos/PepperFlash is built-in to the image and might be out of date in the case of a component update to Flash, right? (That is, they are only redundant if there's been no component push of Flash. Is that correct?)
/home/chronos/PepperFlash is the component Flash that Chrome downloads from Omaha. ImageLoader then copies it into /var/lib/imageloader, but we keep the copy in /home/chronos for the diff updates to work.
Oh, huh. I thought the component-updated version was in /home/chronos/[profile_dir]/PepperFlash.


Given that we already require a restart, would it be reasonable to piggyback off the Linux implementation? How important is 16MB here?
Components: Internals>Plugins>Flash
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment