New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-06
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 851736
issue 851750

Blocking:
issue 751756



Sign in to add a comment
link

Issue 796383: Enable Gerrit CLA for projects that use Chromium CQ service (daemon)

Reported by tandrii@chromium.org, Dec 19 2017 Project Member

Issue description

context: issue 751756 to move a check whether contributor signed CLA from CQ to Gerrit.
 

Comment 1 by tandrii@chromium.org, Dec 20 2017

Plan:

(1) enable this for infra repos, see what breaks.
(2) PSA to chromium-dev s.t. users verify their agreement is shown correctly in 
https://chromium-review.googlesource.com/settings/#Agreements

In early January:
(3) bump PSA
(4) enable Gerrit CLA requirement for chromium/src
(5) instruct other projects to do the same

(6) remove CLA check form CQ of chromium/src and other projects.

Comment 2 by tandrii@chromium.org, Apr 5 2018

(1) done.

Comment 4 by tandrii@chromium.org, Apr 16 2018

(1) went w/o anybody noticing.

Comment 5 Deleted

Comment 6 by tandrii@chromium.org, May 30 2018

Blocking: 751756

Comment 8 by monor...@bugs.chromium.org, Jun 4 2018

The NextAction date has arrived: 2018-06-04

Comment 10 by tandrii@chromium.org, Jun 4 2018

NextAction: 2018-06-06
Temporarily undo because robot account chrome-release-bot@chromium.org apparently doesn't have CLA, we are working on it internally. I'll re-enable Gerrit CLA after that.

Comment 11 by monor...@bugs.chromium.org, Jun 6 2018

The NextAction date has arrived: 2018-06-06

Comment 13 by tandrii@chromium.org, Jun 11 2018

OK, life is good for Chromium/src. Now long tail of repos.

Comment 14 by tandrii@chromium.org, Jun 11 2018

Blockedon: 851736

Comment 15 by bugdroid1@chromium.org, Jun 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69067d7ab0e69fefa3b4dae3b43acc44c53e4c2f

commit 69067d7ab0e69fefa3b4dae3b43acc44c53e4c2f
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Jun 11 23:50:05 2018

cq: remove SignCLA check. Gerrit now enforces up pre-CL-upload.

R=jbudorick@chromium.org

No-Try: True
Bug:  796383 
Change-Id: I30ff15b8893538ed26a23ee4efcfafe793731b44
Reviewed-on: https://chromium-review.googlesource.com/1096423
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566207}
[modify] https://crrev.com/69067d7ab0e69fefa3b4dae3b43acc44c53e4c2f/infra/config/branch/cq.cfg

Comment 16 by bugdroid1@chromium.org, Jun 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/sandbox/+/57539fb06b2c54fd99b95ec8563c28dc60d17ef9

commit 57539fb06b2c54fd99b95ec8563c28dc60d17ef9
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Jun 11 23:54:40 2018

cq: remove SignCLA check. Gerrit now enforces up pre-CL-upload.

TBR=agable@chromium.org

No-Try: True
Bug:  796383 
Change-Id: I29fcadd063952a176777a6f8ca5fa8bc1beef3c8
Reviewed-on: https://chromium-review.googlesource.com/1096431
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/57539fb06b2c54fd99b95ec8563c28dc60d17ef9/infra/config/cq.cfg

Comment 17 by bugdroid1@chromium.org, Jun 12 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/65d78826bd2df74581cda3d5a755b97354da8c15

commit 65d78826bd2df74581cda3d5a755b97354da8c15
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Jun 12 00:02:45 2018

cq: remove SignCLA check. Gerrit now enforces up pre-CL-upload.

R=hinoka, hinoka@chromium.org

Bug:  796383 
Change-Id: I2243244d16b9f58e71c07a2577f713e29af210e5
Reviewed-on: https://chromium-review.googlesource.com/1096425
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/65d78826bd2df74581cda3d5a755b97354da8c15/infra/config/cq.cfg

Comment 18 by bugdroid1@chromium.org, Jun 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b73dff470d94709ebecf9be21618b47bc6bcef5a

commit b73dff470d94709ebecf9be21618b47bc6bcef5a
Author: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 15 03:32:09 2018

Roll src/native_client 82ff2ae08f20..030b88a205c9 (1 commits)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/82ff2ae08f20..030b88a205c9


git log 82ff2ae08f20..030b88a205c9 --date=short --no-merges --format='%ad %ae %s'
2018-06-15 tandrii@chromium.org cq: remove SignCLA check. Gerrit now enforces up pre-CL-upload.


Created with:
  gclient setdep -r src/native_client@030b88a205c9

The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:796383 
TBR=mseaborn@chromium.org

Change-Id: I417019b2a46259d6a2ce50aeec5fcc25d102d3f4
Reviewed-on: https://chromium-review.googlesource.com/1101724
Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567538}
[modify] https://crrev.com/b73dff470d94709ebecf9be21618b47bc6bcef5a/DEPS

Comment 19 by tandrii@chromium.org, Jun 15 2018

Only Skia remains.

Comment 20 by tandrii@chromium.org, Jun 15 2018

Blockedon: 851750

Comment 21 by tandrii@chromium.org, Jul 16 2018

Status: Fixed (was: Started)

Sign in to add a comment