New issue
Advanced search Search tips

Issue 796375 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Dec 2017
Cc:
qyears...@chromium.org
wzang@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

WallPaperPrivateApiTest.WallpaperPrivateApiTest in browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 19 2017 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of qyearsley@google.com

WallPaperPrivateApiTest.WallpaperPrivateApiTest in browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests

Builders failed on: 
- Linux ChromiumOS MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests

Possibly related CL:
https://chromium-review.googlesource.com/c/chromium/src/+/829881

Log excerpt:
[6769:6769:1219/131115.979472:INFO:CONSOLE(0)] "[SUCCESS] setWallpaperFromFileSystem", source: chrome-extension://obklkkbkpaoaejdabbfldmcfplpdgolj/_generated_background_page.html (0)
[6769:6769:1219/131116.290570:INFO:CONSOLE(0)] "[FAIL] getAndSetThumbnail: lastError.message == Only custom wallpaper can change layout.
Error
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at Object.<anonymous> (extensions::test:242:18)
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at Object.callback (extensions::test:293:20)
    at safeCallbackApply (extensions::uncaught_exception_handler:27:15)
    at handleResponse (extensions::sendRequest:67:7)", source: chrome-extension://obklkkbkpaoaejdabbfldmcfplpdgolj/_generated_background_page.html (0)
[6769:6769:1219/131116.447779:INFO:CONSOLE(0)] "[FAIL] getAndSetThumbnail: lastError.message == Only custom wallpaper can change layout.
Error
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at Object.<anonymous> (extensions::test:242:18)
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at Object.callback (extensions::test:293:20)
    at safeCallbackApply (extensions::uncaught_exception_handler:27:15)
    at handleResponse (extensions::sendRequest:67:7)", source: chrome-extension://obklkkbkpaoaejdabbfldmcfplpdgolj/_generated_background_page.html (0)
../../chrome/browser/chromeos/extensions/wallpaper_private_apitest.cc:23: Failure
Value of: RunComponentExtensionTest("wallpaper_manager")
  Actual: false
Expected: true
Failed 2 of 8 tests
[6769:6769:1219/131116.987071:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] WallPaperPrivateApiTest.WallpaperPrivateApiTest, where TypeParam =  and GetParam() =  (6483 ms)

Comment 1 by qyears...@chromium.org, Dec 19 2017

Cc: wzang@chromium.org
Components: Platform>Extensions
xdai@, wzang@, might that change ("wallpaper refactoring: update |current_user_wallpaper_info_| when setting") have affected WallPaperPrivateApiTest.WallpaperPrivateApiTest?

Comment 2 by x...@chromium.org, Dec 19 2017 

Yes. It's a race condition in the tests. I'll land a quick fix. Or if it's urgent, I can revert my CL.

Comment 3 by qyears...@chromium.org, Dec 19 2017 

Not urgent, landing a quick fix should be alright :-)

Comment 4 by x...@chromium.org, Dec 20 2017

Cc: -x...@chromium.org
Owner: x...@chromium.org
Turns out it's more complicated than I thought. Revert the CL first and I'll investigate it later.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e748d831f61d8eb7930ec594a4a937dbbcd8f3d3

commit e748d831f61d8eb7930ec594a4a937dbbcd8f3d3
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Wed Dec 20 01:02:28 2017

Revert "wallpaper refactoring: update |current_user_wallpaper_info_| when setting wallpaper."

This reverts commit 0242859110e56377d3a47f734c802c39aef56478.

Reason for revert: WallPaperPrivateApiTest.WallpaperPrivateApiTest in browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests. 

Original change's description:
> wallpaper refactoring: update |current_user_wallpaper_info_| when setting wallpaper.
> 
> Bug:  794780 
> Change-Id: I1696b84bb4987ab5ccf5c91525a195b110befa70
> Reviewed-on: https://chromium-review.googlesource.com/829881
> Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#525098}

TBR=xdai@chromium.org,wzang@chromium.org

Change-Id: I10afbe5d66f5adf0c2568dd6adacf9e662c6dffc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  794780 ,  796375 
Reviewed-on: https://chromium-review.googlesource.com/835474
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525206}
[modify] https://crrev.com/e748d831f61d8eb7930ec594a4a937dbbcd8f3d3/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/e748d831f61d8eb7930ec594a4a937dbbcd8f3d3/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/e748d831f61d8eb7930ec594a4a937dbbcd8f3d3/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/e748d831f61d8eb7930ec594a4a937dbbcd8f3d3/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
[modify] https://crrev.com/e748d831f61d8eb7930ec594a4a937dbbcd8f3d3/chrome/test/data/extensions/api_test/wallpaper_manager/test.js

Comment 6 by x...@chromium.org, Dec 21 2017

Status: Fixed (was: Available)
►

Sign in to add a comment