New issue
Advanced search Search tips

Issue 796369 link

Starred by 5 users
Status: Assigned
Owner:
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused Cocoa dialog code that's been replaced by a shipped toolkit-views equivalent

Project Member Reported by tapted@chromium.org, Dec 19 2017 
Chrome Version       : 65.0.3294.5

.. otherwise it will just rot.

Initial candidates at this time:
 - permissions bubbles (shipped in m63, Issue 740827)
 - credit card save / card unmask (m64,  Issue 779573,  Issue 776731  )
 - user menu / profile switcher (m64/5,   Issue 728141  )

Fullscreen bubble was removed in  Issue 610900

Comment 1 by tapted@chromium.org, Dec 19 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7016d4297f8d13e46f82546c58509bb4f67dabbb

commit 7016d4297f8d13e46f82546c58509bb4f67dabbb
Author: Mathieu Perreault <mathp@chromium.org>
Date: Sat Feb 03 20:07:28 2018

[Autofill] Remove Cocoa codepaths for save card and card unmask dialogs

Removes a few other classes in the process that are now unneeded.

Bug: 796369
Test: existing
Change-Id: Ia1f9ff91070d73f2288808c68c0375fd8571c0f4
Reviewed-on: https://chromium-review.googlesource.com/834392
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534281}
[modify] https://crrev.com/7016d4297f8d13e46f82546c58509bb4f67dabbb/chrome/browser/about_flags.cc
[modify] https://crrev.com/7016d4297f8d13e46f82546c58509bb4f67dabbb/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/7016d4297f8d13e46f82546c58509bb4f67dabbb/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/autofill_input_field.h
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/autofill_layout.h
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.h
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button_unittest.mm
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/autofill_textfield.h
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/autofill_textfield.mm
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/autofill_textfield_unittest.mm
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_views.mm
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/layout_view.h
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/layout_view.mm
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.h
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm
[modify] https://crrev.com/7016d4297f8d13e46f82546c58509bb4f67dabbb/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_views.h
[modify] https://crrev.com/7016d4297f8d13e46f82546c58509bb4f67dabbb/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_views.mm
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/simple_grid_layout.h
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/simple_grid_layout.mm
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/cocoa/autofill/simple_grid_layout_unittest.mm
[modify] https://crrev.com/7016d4297f8d13e46f82546c58509bb4f67dabbb/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[delete] https://crrev.com/bdcddc95ab232c5fcc45543fac16be313b3cf60d/chrome/browser/ui/views/autofill/card_unmask_prompt_views_shim.cc
[modify] https://crrev.com/7016d4297f8d13e46f82546c58509bb4f67dabbb/chrome/test/BUILD.gn
[modify] https://crrev.com/7016d4297f8d13e46f82546c58509bb4f67dabbb/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/7016d4297f8d13e46f82546c58509bb4f67dabbb/components/autofill/core/browser/autofill_experiments.h

Comment 3 by tapted@chromium.org, Mar 4 2018 

Cocoa Permissions bubble code deleted in https://chromium-review.googlesource.com/c/chromium/src/+/866523 (r529627).

Comment 4 Deleted

Comment 5 by tapted@chromium.org, Mar 22 2018 

Cocoa Profile menu code deleted in https://chromium-review.googlesource.com/c/chromium/src/+/968262 (r545063).

Comment 6 by ellyjo...@chromium.org, Mar 26 2018

Labels: MacViews-Cleanup Target-68
Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)
MacViews triage: I'll own getting this cleanup done, but I'm waiting until after M67 for it.

Comment 7 by gov...@chromium.org, Mar 27 2018

Labels: M-68

Comment 8 by gov...@chromium.org, Mar 29 2018 

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

Comment 9 by gov...@chromium.org, Apr 25 2018 

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.

Comment 10 by tapted@chromium.org, Jun 9 2018

Labels: -M-68 -Target-68
Cocoa password generation removed in https://chromium-review.googlesource.com/1088607 r565669

removing milestone for now - we all have so much on our plate - mid m70 is probably when we can realistically consider systematically purging this stuff.

Comment 11 by robliao@chromium.org, Jul 21

Labels: Group-Cleanup

Comment 12 by jmukthavaram@chromium.org, Nov 23

Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired
***UI Mass Triage ***
Adding labels for expert review.
►

Sign in to add a comment