New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796366 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 678705
issue 896947



Sign in to add a comment

Port TabScrubber to Mash

Project Member Reported by steve...@chromium.org, Dec 19 2017

Issue description

Currently TabScrubber depends on ash::Shell::Get()->AddPreTargetHandler().

This dependency needs to be removed for Mash.

 
Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Labels: Proj-Mustash
Labels: -Proj-Mustash Proj-Mash-SingleProcess
sky says on https://chromium-review.googlesource.com/c/chromium/src/+/1184115

"I suspect this should be !IsUsingWindowService. The reason for that is TabScrubber is watching for gestures on the shell. I suspect that won't work quite right in single process mash either (because the gestures are actually generated in the browser side). It may just work if we switch it to use Env::GetInstance()->AddPretargetHandler()."

Cc: mukai@chromium.org
Labels: -Pri-3 Pri-2
Based on conversation with James, I think for single process mash we should have TabScrubber as a pre-target-handler for both Shell *and* Env. This way it'll pick up scroll gestures not over a browser window.
Owner: rcui@chromium.org
Status: Assigned (was: Available)
Labels: -Proj-Mash-SingleProcess Proj-Mash-MultiProcess
Ryan has a fix out that trivially addresses single-process-mash. Retargetting this to multi-process-mash.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea3bb790e350169ca2bfb439607b89deff5cd689

commit ea3bb790e350169ca2bfb439607b89deff5cd689
Author: Ryan Cui <rcui@chromium.org>
Date: Thu Aug 30 21:30:49 2018

Enable tab scrubber for SingleProcessMash

Verified functionality on an Eve.  This will need to be revisited for
Mash.

BUG: 796366
Change-Id: I7b32728ff2440a8f5cda9b5ac0c28ad30182b145
Reviewed-on: https://chromium-review.googlesource.com/1197367
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ryan Cui <rcui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587777}
[modify] https://crrev.com/ea3bb790e350169ca2bfb439607b89deff5cd689/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc

Blocking: 896947

Sign in to add a comment