New issue
Advanced search Search tips

Issue 796360 link

Starred by 1 user
Status: Fixed
Owner:
tbarzic@chromium.org
Closed: Jan 2018
Cc:
xiy...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove support for loading kiosk OAuth params from oauth token file

Project Member Reported by tbarzic@chromium.org, Dec 19 2017 
When initialized, chromeos::StartupAppLauncher (used to run kiosk app installation and launch) first attempts to load oauth credentials from a local file and inject it into the profile's token service.

Unless there is a valid use case for this, which I might be missing, we should simplify StartupAppLauncher and remove code for this. Worst case, we should add some metrics to confirm whether this is not currently used in production.

xiyuan@ - do you know if there is a reason to keep this around (I remember you tolling me some time ago that support for this file can safely be removed, but I wanted to double check).

Comment 1 by xiy...@chromium.org, Dec 19 2017 

AFAIK, it was added in early days before we wire up identity api and there should be no real use case behind it. I don't think we need it any more.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66de4ebae0ef02f9407e2be43392fa3138a0bbe1

commit 66de4ebae0ef02f9407e2be43392fa3138a0bbe1
Author: Toni Barzic <tbarzic@google.com>
Date: Wed Dec 20 19:24:06 2017

Remove support for oauth params file in chromeos::StartupAppLauncher


While here, make chromeos::StartupAppLauncher use weak ptr factory
instead of overriding SupportsWeakPtr

BUG= 796360 

Change-Id: Ie25a931b513dfdce929ca8625a6fcff4658dde29
Reviewed-on: https://chromium-review.googlesource.com/835268
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525404}
[modify] https://crrev.com/66de4ebae0ef02f9407e2be43392fa3138a0bbe1/chrome/browser/chromeos/app_mode/app_launch_utils.cc
[modify] https://crrev.com/66de4ebae0ef02f9407e2be43392fa3138a0bbe1/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc
[modify] https://crrev.com/66de4ebae0ef02f9407e2be43392fa3138a0bbe1/chrome/browser/chromeos/app_mode/startup_app_launcher.cc
[modify] https://crrev.com/66de4ebae0ef02f9407e2be43392fa3138a0bbe1/chrome/browser/chromeos/app_mode/startup_app_launcher.h
[modify] https://crrev.com/66de4ebae0ef02f9407e2be43392fa3138a0bbe1/chrome/browser/chromeos/login/app_launch_controller.cc
[modify] https://crrev.com/66de4ebae0ef02f9407e2be43392fa3138a0bbe1/chrome/browser/chromeos/login/app_launch_controller.h
[modify] https://crrev.com/66de4ebae0ef02f9407e2be43392fa3138a0bbe1/chrome/browser/chromeos/login/screens/app_launch_splash_screen_view.h
[modify] https://crrev.com/66de4ebae0ef02f9407e2be43392fa3138a0bbe1/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc
[modify] https://crrev.com/66de4ebae0ef02f9407e2be43392fa3138a0bbe1/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.h

Comment 3 by tbarzic@chromium.org, Jan 5 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment