[MD extensions] Update strings |
||||
Issue descriptionThis bug covers several string changes in MD extensions. Notes from Shimi: [These are in no particular order and are numbered for reference] (1) Can we use the Command symbol? "Include Control, Alt, or ⌘"? (to replace "Include Ctrl, Alt, or Command"). (2) Change "Need a character" to "Type a letter" (3) Change "Find extensions and apps in the [...]" to "Find extensions and themes in the Chrome Web Store" (4) In the Details incognito subtext: [...]showing the string in OFF state is confusing. A simple "string only" solution would be to change the subtitle string to say: Warning: Allowed extensions may be able to record*** your browsing history ***Why do we say "recording" your browsing history?? That's not an actual extension permission AFAIK. Should this say "reading" to match current permissions strings? A more elaborate UI change would be to show different strings depending on the toggle state AND on whether the extension even has the relevant permission. (5) Change "Either, not both ctrl and alt" to "Use either Ctrl or Alt" (6) Change "Developer website" to "Open extension website" (7) Change "View in store" to "View in Chrome Web Store"
,
Dec 20 2017
,
Dec 20 2017
,
Dec 20 2017
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9df7cebff6d008e23452f5aca83cd203b19f3832 commit 9df7cebff6d008e23452f5aca83cd203b19f3832 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Dec 22 00:54:17 2017 [MD extensions] Update UI strings This CL changes several UI strings as requested by srahim@. Bug: 796355 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a9428b51eb2336b3c3870a17609a56f14608edf Reviewed-on: https://chromium-review.googlesource.com/837972 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#525878} [modify] https://crrev.com/9df7cebff6d008e23452f5aca83cd203b19f3832/chrome/app/md_extensions_strings.grdp [modify] https://crrev.com/9df7cebff6d008e23452f5aca83cd203b19f3832/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/9df7cebff6d008e23452f5aca83cd203b19f3832/chrome/browser/resources/md_extensions/detail_view.js [modify] https://crrev.com/9df7cebff6d008e23452f5aca83cd203b19f3832/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/9df7cebff6d008e23452f5aca83cd203b19f3832/chrome/test/data/webui/extensions/extension_detail_view_test.js [modify] https://crrev.com/9df7cebff6d008e23452f5aca83cd203b19f3832/chrome/test/data/webui/extensions/extension_shortcut_input_test.js
,
Dec 22 2017
Fixed, sans (4) which was moved in #1. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dschuyler@chromium.org
, Dec 20 2017