New issue
Advanced search Search tips

Issue 796346 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task



Sign in to add a comment

Delete block layout API shims

Project Member Reported by chrishtr@chromium.org, Dec 19 2017

Issue description

The Layout*Item classes other than for line layout are not useful.
They should be deleted.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a000da0e2e2e73eee4041e9ec1247edea576930

commit 0a000da0e2e2e73eee4041e9ec1247edea576930
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Thu Dec 28 05:13:55 2017

Delete parts of the LayoutViewItem API.

Bug:  796346 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic2930394c750a7388f89e06ef63cda184e4eb905
Reviewed-on: https://chromium-review.googlesource.com/838514
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526273}
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/css/CSSCalculationValueTest.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/css/CSSToLengthConversionData.h
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/css/MediaValues.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/css/MediaValuesCached.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/css/MediaValuesDynamic.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/Frame.h
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/VisualViewportTest.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/input/EventHandlingUtil.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/input/MouseWheelEventManager.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/input/TouchActionTest.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/layout/LayoutEmbeddedContent.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/layout/api/LayoutViewItem.h
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/page/PrintContext.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/scheduler/FrameThrottlingTest.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/core/testing/sim/SimCompositor.cpp
[modify] https://crrev.com/0a000da0e2e2e73eee4041e9ec1247edea576930/third_party/WebKit/Source/modules/exported/WebAXObject.cpp

Are even the ones for line layout that useful?
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef2636efffd47cb3112a80c9d331169957c1fb0

commit 2ef2636efffd47cb3112a80c9d331169957c1fb0
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Dec 29 22:37:27 2017

Delete LayoutViewItem.

Bug:  796346 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia9f04ee230cac86b82396294f9d997aded34c70e
Reviewed-on: https://chromium-review.googlesource.com/846499
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526396}
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/css/CSSCalculationValueTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/css/MediaValues.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/css/MediaValuesCached.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/css/MediaValuesDynamic.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/css/MediaValuesInitialViewport.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/css/StyleEngine.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/editing/DragCaret.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/events/WebInputEventConversion.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/events/WebInputEventConversion.h
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/events/WebInputEventConversionTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/exported/WebDocument.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/frame/DocumentLoadingRenderingTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/frame/VisualViewportTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/input/EventHandlingUtil.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/input/MouseWheelEventManager.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/input/TouchActionTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/layout/BUILD.gn
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/layout/IntersectionGeometry.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/layout/LayoutEmbeddedContent.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[delete] https://crrev.com/4c1c5baa34e643d8cd299bf4e7b10c02f9b20adc/third_party/WebKit/Source/core/layout/api/LayoutViewItem.h
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/page/PrintContext.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/paint/compositing/CompositingRequirementsUpdater.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/scheduler/FrameThrottlingTest.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/core/testing/sim/SimCompositor.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/2ef2636efffd47cb3112a80c9d331169957c1fb0/third_party/WebKit/Source/modules/exported/WebAXObject.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/365253129a677835375a8709f26c5e0b5aa0a0b9

commit 365253129a677835375a8709f26c5e0b5aa0a0b9
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Sat Dec 30 01:14:43 2017

Delete LayoutEmbeddedContentItem and LayoutEmbeddedItem.

Bug:  796346 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibd596f04058757a69a1b6923c2595350ceb3ae41
Reviewed-on: https://chromium-review.googlesource.com/846701
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526402}
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/layout/BUILD.gn
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/layout/LayoutView.cpp
[delete] https://crrev.com/18164c8b435f6edb4e2fae41fc3507419e2c75ef/third_party/WebKit/Source/core/layout/api/LayoutEmbeddedContentItem.h
[delete] https://crrev.com/18164c8b435f6edb4e2fae41fc3507419e2c75ef/third_party/WebKit/Source/core/layout/api/LayoutEmbeddedItem.h
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/365253129a677835375a8709f26c5e0b5aa0a0b9/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13103c761bbd7d022db2e892fe12d28fee5f6524

commit 13103c761bbd7d022db2e892fe12d28fee5f6524
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Tue Jan 09 22:53:05 2018

Delete the block layout API shims.

Bug:  796346 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0b0292ab58f79c1e19659c89b1edd52167af2081
Reviewed-on: https://chromium-review.googlesource.com/855824
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528149}
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/events/WebInputEventConversion.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/exported/WebDocument.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/fullscreen/Fullscreen.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/html/ListItemOrdinal.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/BUILD.gn
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/IntersectionGeometry.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/LayoutEmbeddedContent.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutAPIShim.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutBlockItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutBoxModel.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutFullScreenItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutImageItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutLIItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutMenuListItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutProgressItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutSliderItem.cpp
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutSliderItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutTextControlItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutTextFragmentItem.h
[delete] https://crrev.com/dc2e8e02040521801b9d748f6e136847cd379fdb/third_party/WebKit/Source/core/layout/api/LayoutTextItem.h
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/13103c761bbd7d022db2e892fe12d28fee5f6524/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment