New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 796344 link

Starred by 2 users
Status: Fixed
Owner:
█ fsam...@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
jonr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 794961



Sign in to add a comment

FrameSinkManagerImpl::RegisterFrameSinkHierarchy Crashes in viz_browser_tests

Project Member Reported by jonr...@chromium.org, Dec 19 2017 
When running browser_tests with --enable-viz there are some tests crashing in FrameSinkManagerImpl::RegisterFrameSinkHierarchy with:

Check failed: !base::ContainsValue(child_data.parents, parent_frame_sink_id).

The following tests are crashing on Windows and Linux:
WebViewTests/WebViewTest.Shim_TestAssignSrcAfterCrash/0
WebViewTests/WebViewTest.Shim_TestContentScriptIsInjectedAfterTerminateAndReloadWebView/0
WebViewTests/WebViewTest.Shim_TestReloadAfterTerminate/0
WebViewTests/WebViewTest.Shim_TestTerminateAfterExit/0

Comment 1 by jonr...@chromium.org, Mar 12 2018

Cc: jonr...@chromium.org
Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to fsamuel@ as discussed in triage.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fb02122d52f011c6cbe7db0d9b740a10e73385f

commit 9fb02122d52f011c6cbe7db0d9b740a10e73385f
Author: Kevin McNee <mcnee@chromium.org>
Date: Wed Apr 25 20:41:31 2018

Remove BrowserPlugin parameterization of WebView browsertests.

WebViewTests and WebViewInteractiveTests now only run for the
GuestViewCrossProcessFrames enabled case.

Bug: 533069,  544782 , 627962,  796344 , 807116,  818161 ,  818205 ,  829846 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic3a971b553fe343466a440ed4363389cd9e89214
Reviewed-on: https://chromium-review.googlesource.com/1000137
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553727}
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/testing/buildbot/filters/viz.browser_tests.filter

Comment 3 by mcnee@chromium.org, Apr 26 2018

Status: Fixed (was: Assigned)
The /0 versions of these tests have been removed.
►

Sign in to add a comment