cleanup update_payload |
|||
Issue descriptionCleanup update_payload scripts. Most importantly fix the styling issues, unittests problems, etc. This is good to have before starting to add major version 2 in update_engine.
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/b9e91efc7f9b5bb7cb839e9c50c5969eb0f824e8 commit b9e91efc7f9b5bb7cb839e9c50c5969eb0f824e8 Author: Amin Hassani <ahassani@google.com> Date: Wed Jan 03 02:34:14 2018 update_payload: add run_unittests script This allows adding new unittests or modifying them without dealing with the ebuild itself. BUG=chromium:796338 TEST=unittests pass Change-Id: I0876d38a3460b07f611c49554f0a5b2357e09d1f Reviewed-on: https://chromium-review.googlesource.com/834873 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [add] https://crrev.com/b9e91efc7f9b5bb7cb839e9c50c5969eb0f824e8/scripts/run_unittests
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8791ef3a446ee0f3dd75d01d5b81972aea81622c commit 8791ef3a446ee0f3dd75d01d5b81972aea81622c Author: Amin Hassani <ahassani@google.com> Date: Wed Jan 03 22:23:24 2018 update_payload: use run_unittests use new script 'scripts/run_unittests' for running unittests instead of invoking them in the ebuild. This allows us to configure unittests and add more without dealing with the ebuild itself. BUG=chromium:796338 TEST=unittests pass CQ-DEPEND=CL:834873 Change-Id: Ibdc86cf7b8557538fe6200d6fb6caf6924c0e8ed Reviewed-on: https://chromium-review.googlesource.com/834877 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/8791ef3a446ee0f3dd75d01d5b81972aea81622c/chromeos-base/update_payload/update_payload-9999.ebuild
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/52b6039e9c79c20786793e2d1215e20b258f2284 commit 52b6039e9c79c20786793e2d1215e20b258f2284 Author: Amin Hassani <ahassani@google.com> Date: Wed Jan 24 01:41:54 2018 update_payload: use argparse optparse is deprecated (or going to be). Change paycheck.py and blockdiff.py to use argparse instead. Both of these files are being used manually and it would be a good time to fix these before major changes in update_payload. paycheck.sh -h: usage: paycheck.py [-h] [-c] [-D] [-r FILE] [-t {full,delta}] [-z NUM] [-u] [-d] [-k FILE] [-m FILE] [-p NUM] [-P NUM] [-x] [--bspatch-path FILE] [--puffpatch-path FILE] [--dst_kern FILE] [--dst_root FILE] [--src_kern FILE] [--src_root FILE] [-b BLOCK] [-B BLOCK] [-s NUM] PAYLOAD Applies a Chrome OS update PAYLOAD to src_kern and src_root emitting dst_kern and dst_root, respectively. src_kern and src_root are only needed for delta payloads. When no partitions are provided, verifies the payload integrity. positional arguments: PAYLOAD the payload file optional arguments: -h, --help show this help message and exit Checking payload integrity: -c, --check force payload integrity check (e.g. before applying) -D, --describe Print a friendly description of the payload. -r FILE, --report FILE dump payload report (`-' for stdout) -t {full,delta}, --type {full,delta} assert the payload type -z NUM, --block-size NUM assert a non-default (4096) payload block size -u, --allow-unhashed allow unhashed operations -d , --disabled_tests space separated list of tests to disable. allowed options include: dst-pseudo-extents, move-same-src- dst-block, payload-sig -k FILE, --key FILE override standard key used for signature validation -m FILE, --meta-sig FILE verify metadata against its signature -p NUM, --root-part-size NUM override rootfs partition size auto-inference -P NUM, --kern-part-size NUM override kernel partition size auto-inference Applying payload: -x, --extract-bsdiff use temp input/output files with BSDIFF operations (not in-place) --bspatch-path FILE use the specified bspatch binary --puffpatch-path FILE use the specified puffpatch binary --dst_kern FILE destination kernel partition file --dst_root FILE destination root partition file --src_kern FILE source kernel partition file --src_root FILE source root partition file Block tracing: -b BLOCK, --root-block BLOCK trace the origin for a rootfs block -B BLOCK, --kern-block BLOCK trace the origin for a kernel block -s NUM, --skip NUM skip first NUM occurrences of traced block Note: a payload may verify correctly but fail to apply, and vice versa; this is by design and can be thought of as static vs dynamic correctness. A payload that both verifies and applies correctly should be safe for use by the Chrome OS Update Engine. Use --check to verify a payload prior to applying it. BUG=chromium:796338 TEST=unitests TEST=test_paycheck.sh TEST=blockdiff.py Change-Id: I794b5f61e6ba6f92939947c97c432f9fea0b6b3c Reviewed-on: https://chromium-review.googlesource.com/834876 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Sen Jiang <senj@chromium.org> [modify] https://crrev.com/52b6039e9c79c20786793e2d1215e20b258f2284/scripts/blockdiff.py [modify] https://crrev.com/52b6039e9c79c20786793e2d1215e20b258f2284/scripts/test_paycheck.sh [modify] https://crrev.com/52b6039e9c79c20786793e2d1215e20b258f2284/scripts/paycheck.py
,
Aug 1
,
Dec 18
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ahass...@chromium.org
, Dec 19 2017