New issue
Advanced search Search tips

Issue 796335 link

Starred by 1 user
Status: Fixed
Owner:
skobes@chromium.org
Closed: Dec 2017
Cc:
szager@chromium.org
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 544140



Sign in to add a comment

[root layer scrolls] iframe-composited-scrolling.html

Project Member Reported by skobes@chromium.org, Dec 19 2017 
This test is flaky with RLS (on at least Linux, possibly all platforms).  Sometimes it prints "FAIL".

The root cause seems to be that Page::NonFastScrollableRects doesn't force a compositing update.  It calls ScrollingCoordinator::UpdateAfterCompositingChangeIfNeeded, but this method assumes we are already >= kCompositingClean.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd558ee95165ef2ebbd1c22cd5d6e2fa876a85b8

commit bd558ee95165ef2ebbd1c22cd5d6e2fa876a85b8
Author: Steve Kobes <skobes@chromium.org>
Date: Wed Dec 20 01:46:48 2017

Ensure clean compositing state in Page::NonFastScrollableRects.

This de-flakes compositing/iframes/iframe-composited-scrolling.html when
root layer scrolling is enabled.

Bug:  796335 
Change-Id: Iec78032b48f90b9775dd6ef30826a0da0b328acf
Reviewed-on: https://chromium-review.googlesource.com/834871
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525220}
[modify] https://crrev.com/bd558ee95165ef2ebbd1c22cd5d6e2fa876a85b8/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/bd558ee95165ef2ebbd1c22cd5d6e2fa876a85b8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bd558ee95165ef2ebbd1c22cd5d6e2fa876a85b8/third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-transform-changed-expected.txt
[modify] https://crrev.com/bd558ee95165ef2ebbd1c22cd5d6e2fa876a85b8/third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-transform-changed.html
[modify] https://crrev.com/bd558ee95165ef2ebbd1c22cd5d6e2fa876a85b8/third_party/WebKit/Source/core/page/Page.cpp

Comment 2 by skobes@chromium.org, Dec 20 2017

Status: Fixed (was: Started)
►

Sign in to add a comment