New issue
Advanced search Search tips

Issue 796327 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Only send ScreenInfo to BrowserPlugins embedded by RenderWidget

Project Member Reported by samans@chromium.org, Dec 19 2017

Issue description

Currently in RenderWidget whenever ScreenInfo is changed we notify all BrowserPlugins in the renderer. This is wrong. Only the BrowserPlugins embedded by that RenderWidget should be notified. This has caused rendering issues with pdf files both with and without surface sync.

Reproduction steps:
1) Run out/Default/chrome --ash-host-window-bounds=900x900*2,900+0-900x900 --renderer-process-limit=1
2) In the first (high dpi) display, in two separate browser windows open two pdf files (for example https://pdfobject.com/pdf/sample-3pp.pdf)
3) Drag one window to the second (low-dpi) display.

What is the expected result?
The pdf file in the high-dpi display is rendered properly.

What happens instead?
The pdf file in the high-dpi display is blurry and remains forever blurry.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d189e5dfd36549e7078ce0223bec0076bed9a470

commit d189e5dfd36549e7078ce0223bec0076bed9a470
Author: Saman Sami <samans@chromium.org>
Date: Wed Dec 20 22:55:31 2017

Fix propagation of ScreenInfo to BrowserPlugins

Currently in RenderWidget whenever ScreenInfo is changed we notify all
BrowserPlugins in the renderer. This is wrong. Only the BrowserPlugins
embedded by that RenderWidget should be notified. This has caused
rendering issues with pdf files both with and without surface sync.

Bug:  796327 
Change-Id: I4d8789f809679edba2effe5af95c854bf229187e
Reviewed-on: https://chromium-review.googlesource.com/834152
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525502}
[modify] https://crrev.com/d189e5dfd36549e7078ce0223bec0076bed9a470/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/d189e5dfd36549e7078ce0223bec0076bed9a470/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/d189e5dfd36549e7078ce0223bec0076bed9a470/content/renderer/browser_plugin/browser_plugin_manager.cc
[modify] https://crrev.com/d189e5dfd36549e7078ce0223bec0076bed9a470/content/renderer/browser_plugin/browser_plugin_manager.h
[modify] https://crrev.com/d189e5dfd36549e7078ce0223bec0076bed9a470/content/renderer/render_widget.cc
[modify] https://crrev.com/d189e5dfd36549e7078ce0223bec0076bed9a470/content/renderer/render_widget.h

Comment 2 by samans@chromium.org, Dec 20 2017

Status: Fixed (was: Started)

Sign in to add a comment