New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796312 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Left Chrome team
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix incorrect use of DISABLE_NETWORK_PREDICTION_FLAG

Project Member Reported by mariakho...@chromium.org, Dec 19 2017

Issue description

The constant DISABLE_NETWORK_PREDICTION_FLAG="--disable-features=NetworkPrediction" doesn't work correctly because CommandLineFlags.Add() expects the input to not include "--" character for the switch name and hence doesn't interpret the input correctly.

This has not been working for quite some time now. I believe this flag can just be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8310f7eeb528b65fa963cb110e22334ec15f58e

commit e8310f7eeb528b65fa963cb110e22334ec15f58e
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Tue Dec 19 22:28:40 2017

Stop using DISABLE_NETWORK_PREDICTION_FLAG.

This flag used to disable a different prefetch feature ostensibly because
the feature didn't play well with the Java test server. Then during a
refactoring the other feature got rolled into network prediction feature
and since then network prediction feature has launched on by default.

Actually turning off network prediction feature makes a number of tests fail
because they legitimately expect the functionality to work.

Instead, I believe this disabling hasn't been working for quite some time and
can be removed altogether. Since 287 different files reference this constant,
my plan is to first submit this change to ensure there weren't test case
runners that actually managed to parse the flag correctly (CQ already passes)
and then remove all references in a second change.

Bug:  796312 
Change-Id: I93589e9e6432dc34ce7486ecdd0b216514494310
Reviewed-on: https://chromium-review.googlesource.com/831108
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525159}
[modify] https://crrev.com/e8310f7eeb528b65fa963cb110e22334ec15f58e/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestRule.java

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/f58a9822692a12b53ebcd75fd2c387987878eb02

commit f58a9822692a12b53ebcd75fd2c387987878eb02
Author: Maria Khomenko <mariakhomenko@google.com>
Date: Fri Dec 22 00:19:43 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88ba4459d82e586770f448ef303fda34a84a28ab

commit 88ba4459d82e586770f448ef303fda34a84a28ab
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Fri Dec 22 04:36:01 2017

Remove DISABLE_NETWORK_PREDICTION_FLAG.

This flag is a no-op, cleaning up the usage.

Bug:  796312 
Change-Id: Ie51ee9b68ece4383713a0bb912db2ff73e0f3512
Reviewed-on: https://chromium-review.googlesource.com/835408
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525932}
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/AudioTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeActivityTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ContentViewFocusTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/FocusedEditableTextFieldZoomTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/HTTPSTabsOpenedFromExternalAppTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/InstalledAppTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/JavaScriptEvalChromeTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/MainActivityWithURLTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/PopularUrlsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/PowerBroadcastReceiverTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/PrerenderTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ProcessIsolationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/RepostFormWarningTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/RestoreHistogramTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/SelectFileDialogTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ShareIntentTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/TabCountLabelTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/TabObserverTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/TabTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/TabThemeTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/UrlSchemeTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/WebShareTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/DataSaverAppMenuTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/browsing_data/BrowsingDataRemoverIntegrationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/CompositorVisibilityTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/overlays/strip/TabStripTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicyTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequestTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/document/LauncherActivityTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeHomeDownloadManagerTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/engagement/SiteEngagementServiceTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/hardware_acceleration/ChromeTabbedActivityHWATest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/hardware_acceleration/CustomTabActivityHWATest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/hardware_acceleration/ToastHWATest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/hardware_acceleration/WebappActivityHWATest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/IncognitoNotificationServiceTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarAppearanceTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/instantapps/InstantAppsHandlerTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapterTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastNotificationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastPositionTransferTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastStartStopTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastSwitchVideoTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastVideoControlsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/AutoplayMutedNotificationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/metrics/MainIntentBehaviorMetricsIntegrationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/metrics/PageLoadMetricsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/metrics/UkmIncognitoTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/multiwindow/MultiWindowIntegrationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtilsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageLoadTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageNavigationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/RecentTabsPageTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItemTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/MHTMLPageTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/RecentTabsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/BottomSheetLocationBarTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerDisableIncognitoModeIntegrationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageIntegrationTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentManifestDownloaderTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentManifestParserTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestAbortTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressWithoutPhoneTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBlobUrlTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryNoCardTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryNoCardTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDataUrlTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDebitTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDontHaveDebitTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndPhoneTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmptyUpdateTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExpiredLocalCardTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExtraShippingOptionsTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFailCompleteTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFieldTrialTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIdTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/88ba4459d82e586770f448ef303fda34a84a28ab/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDet
Status: Fixed (was: Assigned)

Sign in to add a comment