PkpTests are consistently failing on ios-simulator-cronet bots. |
|||||
Issue descriptionIt looks like 4 PkpTests are failing consistently on Cronet bots. Here are 3 failures from different, unrelated CLs: https://ci.chromium.org/buildbot/tryserver.chromium.mac/ios-simulator-cronet/3125 https://ci.chromium.org/buildbot/tryserver.chromium.mac/ios-simulator-cronet/3126 https://ci.chromium.org/buildbot/tryserver.chromium.mac/ios-simulator-cronet/3127 So it's currently impossible to land anything that touches a file used on ios Cronet. Misha: Mind triaging?
,
Dec 19 2017
PkpTest.TestSuccessIfPinSetForDifferentHost:
[33872:1027:1219/114130.869859:31490556741008:INFO:quic_test_server.cc(115)] 0x0
[1219/114130.897123:WARNING:proof_verifier_chromium.cc(501)] Failed to verify certificate chain: net::ERR_CERT_INVALID
[1219/114130.897829:ERROR:crn_http_protocol_handler.mm(814)] HttpProtocolHandlerCore - Network error: net::ERR_QUIC_PROTOCOL_ERROR (-356)
../../components/cronet/ios/test/cronet_pkp_test.mm:70: Failure
Value of: IsResponseSuccessful()
Actual: false (error in response: Error Domain=NSURLErrorDomain Code=-1004 "(null)" UserInfo={NSUnderlyingError=0x60400005eb40 {Error Domain=net Code=-356 "(null)"}, CreationDate=2017-12-19 19:41:30 +0000, NSErrorFailingURLStringKey=https://test.example.com/simple.txt})
Expected: true
../../components/cronet/ios/test/cronet_pkp_test.mm:127: Failure
Expected: sendRequestAndAssertResult(request_url_, kSuccess) doesn't generate new fatal failures in the current thread.
Actual: it does.
[1219/114130.902448:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
,
Dec 19 2017
I'll try it locally to see if it is configuration or code issue.
,
Dec 19 2017
It reproduces locally, I'll try to bisect
,
Dec 19 2017
This is caused by https://chromium-review.googlesource.com/c/chromium/src/+/833749 Should I revert it or can it be fixed forward?
,
Dec 19 2017
I'd say reverted, if it can't be fixed tonight (Or at least get an ETA on it tonight) - it's blocking the CQ. And while people can just bypass the bots, that shouldn't be a usual part of the workflow, and people could break more tests without noticing if they do that.
,
Dec 19 2017
let me take a look first. how come this isn't on the cq?
,
Dec 19 2017
There doesn't even seem to be a non-FYI buildbot, either. :(
,
Dec 19 2017
Micha pointed out that my subsequent cl, https://chromium-review.googlesource.com/c/chromium/src/+/834748/3/components/cronet/ios/test/cronet_pkp_test.mm#b28, fixes this. i'll try to land the one ios change separately first.
,
Dec 19 2017
sgtm, thanks!
,
Dec 19 2017
fix should be landing soon: https://chromium-review.googlesource.com/c/chromium/src/+/834994
,
Dec 19 2017
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e71500196b7e172b7c826febe6361e98890ea255 commit e71500196b7e172b7c826febe6361e98890ea255 Author: John Abd-El-Malek <jam@chromium.org> Date: Tue Dec 19 22:33:02 2017 Fix iOS QUIC unittests on ios-simulator-cronet after r525102. Bug: 796311 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7aeb3767ef4e5b883a8b83e29fe24b786a84f1c1 Reviewed-on: https://chromium-review.googlesource.com/834994 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#525160} [modify] https://crrev.com/e71500196b7e172b7c826febe6361e98890ea255/components/cronet/ios/test/cronet_pkp_test.mm
,
Dec 19 2017
Wow, that was fast. Thanks!
,
Dec 19 2017
We aim to please. :) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mef@chromium.org
, Dec 19 2017Owner: kapishnikov@chromium.org