"ContinueWhereILeftOffTest.PostCloseAllBrowsers" is flaky |
|||||
Issue description"ContinueWhereILeftOffTest.PostCloseAllBrowsers" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5Db250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LlBvc3RDbG9zZUFsbEJyb3dzZXJzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Dec 20 2017
,
Dec 20 2017
I have just moved it (as a part of removing unnecessary dependency on Background mode from ChromeOS) in the file, so that there is just single #if check. Here is the git-blame link before my change: https://chromium.googlesource.com/chromium/src/+blame/a796fa5605119535041802efe09b9e98099273d1/chrome/browser/sessions/better_session_restore_browsertest.cc#677
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62de24e052084bb27e3390cbeb14507bd5680969 commit 62de24e052084bb27e3390cbeb14507bd5680969 Author: Roger McFarlane <rogerm@chromium.org> Date: Wed Dec 20 16:48:45 2017 Disable ContinueWhereILeftOffTest.PostCloseAllBrowsers Test has been flaky. TBR=jochen@chromium.org,antrim@chromium.org Bug: 796308, 527045 Change-Id: Ifd05e090d8067cd43d016c38d26d203e4ac337f8 Reviewed-on: https://chromium-review.googlesource.com/836812 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#525349} [modify] https://crrev.com/62de24e052084bb27e3390cbeb14507bd5680969/chrome/browser/sessions/better_session_restore_browsertest.cc
,
Dec 20 2017
Per comment 3, assigning to previous blame-owner (sammc@) for triage or reroute to a more current owner. Thanks.
,
Jan 4 2018
This only flaked with the network service enabled. I'm reverting the disable. Reassigning to jam@ to triage.
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23440e051356907fecd44218c9c89b50df55abb8 commit 23440e051356907fecd44218c9c89b50df55abb8 Author: Sam McNally <sammc@chromium.org> Date: Thu Jan 04 08:10:27 2018 Revert "Disable ContinueWhereILeftOffTest.PostCloseAllBrowsers" This reverts commit 62de24e052084bb27e3390cbeb14507bd5680969. Reason for revert: Test only flaked with network service enabled. Original change's description: > Disable ContinueWhereILeftOffTest.PostCloseAllBrowsers > > Test has been flaky. > > TBR=jochen@chromium.org,antrim@chromium.org > > Bug: 796308, 527045 > Change-Id: Ifd05e090d8067cd43d016c38d26d203e4ac337f8 > Reviewed-on: https://chromium-review.googlesource.com/836812 > Commit-Queue: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525349} TBR=antrim@chromium.org,rogerm@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 796308 Change-Id: I8960b4e9b1873e18e8bd496e7619594c82411137 Reviewed-on: https://chromium-review.googlesource.com/848557 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526938} [modify] https://crrev.com/23440e051356907fecd44218c9c89b50df55abb8/chrome/browser/sessions/better_session_restore_browsertest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rogerm@chromium.org
, Dec 20 2017Status: Assigned (was: Untriaged)