Issue metadata
Sign in to add a comment
|
Start page duplicated if are blocked
Reported by
dwhitz...@gmail.com,
Dec 19 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36 Steps to reproduce the problem: 1. Go to settings chrome://settings/ 2. Scroll down to Start Page section 3. Set at least one start page 4. Restart chrome chrome://restart 5. Now block all the tab start pages opened. 6. Restart chrome again chrome://restart 7. Now chrome will open the start pages as tab BLOCKED and the start pages NOT blocked . So if we set 3 start pages (gmail, youtube, G Photos). We will see 3 blocked tabs(gmail, youtube, G Photos) and three normal tab (gmail, youtube, Photos). Note: Use chrome://restart to restart chrome is very important to reproduce the bug, otherwise you should manualy kills all the chrome processes. What is the expected behavior? If the start pages were blocked, Chrome must open the start pages as BLOCKED tabs without duplicate them as normal tabs What went wrong? I think that chrome doesn't check if the start pages are already present as blocked tabs. Did this work before? No Chrome version: 63.0.3239.108 Channel: stable OS Version: 10.0 Flash Version: This bug is reproducible since v.61
,
Dec 27 2017
Unable to reproduce the issue on Win-10 using chrome reported version #63.0.3239.108 and latest canary #65.0.3304.0. Attached a screen cast for reference. Following are the steps followed to reproduce the issue. ------------ 1. Navigated to settings chrome://settings/ 2. Scrolled down to Start Page section 3. Set at least one start page i.e www.youtube.com 4. Restart chrome chrome://restart 5. Now blocked/pinned all the tab start pages opened. 6. Restarted chrome again chrome://restart. 7. Observed that chrome opened the start pages as BLOCKED tabs without duplicate them as normal tabs as expected. reporter@ - Could you please check the issue on latest stable #65.0.3304.0 by creating a new profile without any apps and extensions and please let us know if the issue still persist or not. Thanks...!!
,
Dec 28 2017
Just re-tested with your version and is still happening
,
Dec 28 2017
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 29 2017
Able to reproduce this issue on reported version 63.0.3239.108 and on latest canary 65.0.3307.0 using windows10, Ubuntu 14.04 with steps mentioned in comment#0. In Mac pinned tabs doesn't get opened on re-opening chrome. Good Build: 58.0.2999.0 Bad Build: 58.0.3000.0 You are probably looking for a change made after 447607 (known good), but no later than 447608 (first known bad). https://chromium.googlesource.com/chromium/src/+log/e027f6a77853952285de14c8b9009c208b4c2c99..f9a9ef14dfdb45e70a898024b5c690ac4bf3a5e Review-Url: https://codereview.chromium.org/2627363002 Suspecting the same changelog @tmartino: Please confirm the issue and help in re-assigning if it is not related to your change. Thanks!
,
Dec 29 2017
,
Jan 8 2018
Hi there, When reimplementing this last year, we decided that this behavior was desired. This was because: - Doing otherwise adds a lot of code complexity - The number of users who have both pinned tabs and preferences-specified tabs is quite small To give a better explanation of the complexity, it turns out to be quite difficult to determine when the pinned and preferences URLs overlap. We used to check for an exact URL text match, but it was highly unreliable. This is because the pinned tab holds the *last* URL contained in that tab, rather than the URL you originally navigated to. Many major websites redirect you to another URL on load--for example, if I put "google.com" in my startup URLs, by the time the page loads, my URL is something like: "https://www.google.ca/?foo=bar&id=baz123". The only way to be sure that these shouldn't be duplicated would be to actually resolve the URL (i.e., attempt to load the page and see what happens)--and even then, it wouldn't account for lots of pages where the final URL you land on may change each time. It just doesn't make sense given how slow that would make startup. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Dec 20 2017