New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796282 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 771178
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ash_unittests should exercise production display management codepaths

Project Member Reported by msw@chromium.org, Dec 19 2017

Issue description

ash_unittests should exercise production display management codepaths

Chrome OS uses DisplayConfigurator for on-device (production) display management/config.
But ash_unittests generally don't use this component, even when the focus of the test is display management/config.

1) AshTestBase automatically appends a default kHostWindowBounds commandline switch via AshTestHelper::SetUp:
   https://cs.chromium.org/chromium/src/ash/test/ash_test_helper.cc?rcl=4667c1c87d4746c53e39be01bd6b7bc4dd8e75bf&l=84
2) That causes ash::Shell::Init to deviate from the on-device production display management/config codepath:
   https://cs.chromium.org/chromium/src/ash/shell.cc?rcl=4667c1c87d4746c53e39be01bd6b7bc4dd8e75bf&l=886

So ash_unittests fakes everything out at the display::DisplayManager level and never test DisplayConfigurator.
There are some specific display_unittests exercising DisplayConfigurator, but the pattern above seems bad.
It seems like ash_unittests should generally use DisplayConfigurator, at least going forward in mus/mash.

Maybe linux-desktop Chrome OS should also use DisplayConfigurator in cash (it already does in mus/mash).

Please weigh in with any thoughts or advice, thanks! (I'm still not very familiar with this area)
 

Comment 1 by osh...@chromium.org, Dec 19 2017

Cc: afakhry@chromium.org
crbug.com/771178 should cover this. Please sync up with afakhry@ if you're planning to do this sooner.

Comment 2 by msw@chromium.org, Dec 21 2017

Mergedinto: 771178
Status: Duplicate (was: Assigned)
Good to know. I suppose it's reasonable to dup this bug against that one.
afakhry, I don't have immediate plans to work on this, but might be able to pitch in.
Components: -MUS Internals>Services>WindowService

Sign in to add a comment