New issue
Advanced search Search tips

Issue 796262 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ChromeVox arrow keys should navigate through shelf and status area in views-based login/lock

Project Member Reported by jdufault@chromium.org, Dec 19 2017

Issue description

ChromeVow arrow keys should navigate through shelf and status area in views-based login/lock.

The lock screen, shelf, and status area are all different widgets without a clear parent which makes this tricky.

This looks like it will require changes in ChromeVox. A couple of approaches I've played with:

- https://chromium-review.googlesource.com/c/chromium/src/+/827634
- https://chromium-review.googlesource.com/c/chromium/src/+/828269
- https://chromium-review.googlesource.com/c/chromium/src/+/831053
 
Summary: ChromeVox arrow keys should navigate through shelf and status area in views-based login/lock (was: ChromeVow arrow keys should navigate through shelf and status area in views-based login/lock)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da

commit 72cfcc02fb9c1ce5a011a238bcf9171754f0d6da
Author: David Tseng <dtseng@chromium.org>
Date: Fri Dec 22 03:02:40 2017

Introduce next and previous focusable for views in chrome.automation

Bug:  796262 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I501e863757ae44657c8c4611d7adf2284489fe29
Reviewed-on: https://chromium-review.googlesource.com/830913
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525915}
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/ash/login/ui/lock_screen.h
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/ash/shelf/login_shelf_view.h
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/content/browser/accessibility/accessibility_tree_formatter_blink.cc
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/72cfcc02fb9c1ce5a011a238bcf9171754f0d6da/ui/accessibility/ax_node_data.cc

Comment 3 by dtseng@chromium.org, Dec 22 2017

Status: fixed (was: Assigned)

Sign in to add a comment