New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 796253 link

Starred by 1 user
Status: Fixed
Owner:
█ holte@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Make test names between iOS and non-iOS UKM tests consistent

Project Member Reported by bmcquade@chromium.org, Dec 19 2017 
Chris Palmer notes:
it would help to harmonize the test names between ukm_egtest.mm and ukm_browsertest.cc, to the extent possible. I read them side-by-side and tried to match the tests up, but I may have gotten some wrong.

This is in reference to tests like
UkmBrowserTest.SyncSignoutCheck, UkmBrowserTest.DisableSyncCheck, and the ios testNoSync test.

Let's try to synchronize these and also add ifchange lints in the 2 files for matching tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7b67e7ef95d2c9ea5c648613aebab378f01d849

commit f7b67e7ef95d2c9ea5c648613aebab378f01d849
Author: Steven Holte <holte@chromium.org>
Date: Mon Jan 22 19:27:43 2018

Add UkmTest ConsentAddedButNoSync for iOS.

Also rearranges and renames tests to better correllate with ukm_browsertests.

Bug:  796253 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I29eda9240dedf46b07c499c276a7fb35f9101d93
Reviewed-on: https://chromium-review.googlesource.com/875123
Reviewed-by: Louis Romero <lpromero@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530946}
[modify] https://crrev.com/f7b67e7ef95d2c9ea5c648613aebab378f01d849/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/f7b67e7ef95d2c9ea5c648613aebab378f01d849/ios/chrome/browser/metrics/ukm_egtest.mm

Comment 2 by holte@chromium.org, Jan 30 2018

Owner: holte@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment