New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796246 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

smbprovider: Add support for has_more in ReadDirectory

Project Member Reported by allenvic@chromium.org, Dec 19 2017

Issue description

Feature description:  Implement has_more in ReadDirectory 

ReadDirectory is currently implemented in a way that reads the whole directory at once, no matter what size. has_more is currently always set to false. has_more should be implemented to support paging
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88d5add9736bd3fc27c7ef1cb705b13489289a22

commit 88d5add9736bd3fc27c7ef1cb705b13489289a22
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Feb 09 04:15:43 2018

Implement has_more for ReadDirectory

Implements has_more in SmbFileSystem for ReadDirectory. This allows
SmbFileSystem to deliver the first page of results without waiting for
the whole list of results.

Bug:  chromium:796246 
Change-Id: Ia05917bcaeb598de5fa755a8fe18d50de9165575
Reviewed-on: https://chromium-review.googlesource.com/908054
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535638}
[modify] https://crrev.com/88d5add9736bd3fc27c7ef1cb705b13489289a22/chrome/browser/chromeos/smb_client/smb_file_system.cc

Status: Verified (was: Assigned)

Sign in to add a comment