Issue 796242 link

Starred by 1 user

Issue metadata

Status:	Assigned
Owner:	mxnguyen@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Correct nextversion when sending extension uninstall

Project Member Reported by mxnguyen@chromium.org, Dec 19 2017

Issue description

Currently, when uninstalling an extension, update_client will set nextversion="0" in the uninstall ping event, and through the "magic" of interpreting when nextversion="0", the server will change the event's version to "0.0.0.0" resulting in the extension uninstall data having no version number. 

We need to change this logic by not sending nextversion like this, probably by setting it to the same as version?

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01d3586d8b9c330f38d0e266cd74c1ad1738086c

commit 01d3586d8b9c330f38d0e266cd74c1ad1738086c
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Fri Jan 05 20:41:10 2018

[Component] Correct nextversion to be sent when uninstalling an extension/component.

Bug: 796242
Change-Id: I3a82be034512cc907e8b21390f4c3179ec01e7f9
Reviewed-on: https://chromium-review.googlesource.com/833210
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527371}
[modify] https://crrev.com/01d3586d8b9c330f38d0e266cd74c1ad1738086c/components/update_client/component.cc
[modify] https://crrev.com/01d3586d8b9c330f38d0e266cd74c1ad1738086c/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/01d3586d8b9c330f38d0e266cd74c1ad1738086c/components/update_client/protocol_builder.cc
[modify] https://crrev.com/01d3586d8b9c330f38d0e266cd74c1ad1738086c/components/update_client/protocol_builder.h
[modify] https://crrev.com/01d3586d8b9c330f38d0e266cd74c1ad1738086c/components/update_client/update_client_unittest.cc

Comment 2 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)

►

Issue 796242 link

Issue metadata

Correct nextversion when sending extension uninstall

Issue description

Comment 1 by bugdroid1@chromium.org, Jan 5 2018

Comment 1 Deleted

Comment 2 by benhenry@chromium.org, Aug 1

Comment 2 Deleted

Sign in to add a comment