Clarify the behavior of views based shelf on secondary display on lock and login screens. |
||||||||
Issue descriptionWhen web UI is used shelf is only visible on primary display on lock and login screens. When views based lock is used, shelf is visible also on secondary display. Turning on views based login will cause shelf visibility on login screen on secondary display. I would like to clarify the desired behavior for secondary display: * shelf visible/invisible on secondary display on lock screen * shelf visible/invisible on secondary display on login screen and get prioritization of fix if needed.
,
Dec 19 2017
,
Dec 19 2017
+Jenn too since Maria is OOO. Elizabeth, Jenn, WDYT?
,
Dec 19 2017
,
Jan 3 2018
Jenn, Elizabeth, WDYT about that?
,
Jan 4 2018
,
Jan 4 2018
Since there isn't anything much on the extended secondary display and the shelf has log-in critical UI (e.g. sign out and add user), we should continue not showing the shelf on non-primary displays as is today's behavior.
,
Jan 5 2018
Sorry for taking so long to respond as I was OOO. I totally agree with Jenn. Let's not show the shelf on non-primary displays.
,
Jan 5 2018
Thanks for answers! And what about system tray?
,
Jan 5 2018
Same deal — no system tray either since there's no shelf. So there wouldn't be much other than a blurred wallpaper.
,
Jan 5 2018
Thx! I will take of that.
,
Jan 11 2018
Make sure that LoginScreenController::SetSystemTrayVisibility() only affects primary display. Consider renaming the function to SetPrimarySystemTrayVisibility() to emphasize that fact.
,
Jan 18 2018
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e commit a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e Author: Aga Wronska <agawronska@chromium.org> Date: Mon Jan 29 16:06:44 2018 Do not show shelf nor system tray on secondary displays in lock and login states. Add logic to hide shelf on secondary display to ShelfWidget. Add logic to hide system tray on secondary screen to LoginScreenController. Set hide state for shelf on secondary display in ShelfLayoutManager::UpdateVisibilityState(). Otherwise system tray will be displayed on secondary display despite calls from LoginScreenController. Bug: 796239 Change-Id: I941507860e2b4800a1f396ff3e8d6bdf09d95fda Reviewed-on: https://chromium-review.googlesource.com/885581 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#532445} [modify] https://crrev.com/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e/ash/login/login_screen_controller.cc [modify] https://crrev.com/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e/ash/login/login_screen_controller_unittest.cc [modify] https://crrev.com/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e/ash/root_window_controller.cc [modify] https://crrev.com/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e/ash/shelf/shelf.cc [modify] https://crrev.com/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e/ash/shelf/shelf.h [modify] https://crrev.com/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e/ash/shelf/shelf_widget.cc [modify] https://crrev.com/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e/ash/shelf/shelf_widget_unittest.cc [modify] https://crrev.com/a844cdcd1d7dcb6d9ac577d7d7a612602ae18c0e/ash/wm/lock_action_handler_layout_manager_unittest.cc
,
Jan 29 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by r...@chromium.org
, Dec 19 2017Status: Assigned (was: Untriaged)