CQ Gerrit reference links are broken |
|||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 Steps to reproduce the problem: 1. Create a change 2. Upload to gerrit 3. Submit the change to CQ What is the expected behavior? User should get an email like: """ CQ is trying the patch. ... Reference: hostname/c/<issue>/<patchset> """ What went wrong? User gets an email saying: """ CQ is trying the patch. ... Reference: hostname/<issue>/<patchset> """ C is missing ------^ Did this work before? No Chrome version: 63.0.3239.84 Channel: n/a OS Version: Flash Version: We can fix this by updating our hostname (somewhere?) to include the trailing /c/ but that wouldn't be ideal because it isn't a true hostname and would likely break if the Gerrit link changed in the future. For an example, see: https://fuchsia.atlassian.net/secure/RapidBoard.jspa?rapidView=38&selectedIssue=INTK-83
,
Dec 20 2017
Thanks for filing the issue @Reporter: Can you please provide the sample test file/URL and test credentials to test this issue which helps us to triage it in a better way from TE end. NOTE: Tried to login into the sample URL provided i.e.,"https://fuchsia.atlassian.net/secure/RapidBoard.jspa?rapidView=38&selectedIssue=INTK-83", but unable to login into it my existing account, hence requesting for test credentials Thanks!
,
Dec 20 2017
,
Jan 5 2018
Hi, there is no sample test file/URL per say. This is a recurring problem when submitting patches to CQ. I believe this should be a problem for all projects that are using CQ if the bug originates from the chromium_infra_internal link I provided (and should be testable by sending a patch to any project's CQ) The link I provided is just a link to an existing, identical bug on Fuchsia's JIRA tracker. The example / original contents of that message are: ` I get emails like: CQ is trying the patch. Note: The patchset sent to CQ was uploaded after this CL was approved. "" https://turquoise-internal-review.googlesource.com/c/20130/5 Reference: turquoise-internal-review.googlesource.com/20130/5 Bot data: {"action": "start", "triggered_at": "2017-12-14T18:53:26.0Z", "cq_cfg_revision": "9876df02ebee522aac7407088208abb2eb4b451a", "revision": "a08e61e40c043794beb144724d44c67e7b999a43"} The first link is valid but the "Reference:" link 404s - it's missing the /c/ after the hostname. `
,
Jan 5 2018
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 12 2018
Friendly ping. Has any progress been made on this?
,
Jan 17 2018
Bumping again on this. This is low priority but I would appreciate if someone could look into whether all that is needed is to change the string format at: http://cs/chromium_infra_internal/infra_internal/services/cq/pending_manager/base.py?l=48&rcl=c7b89c4b0a1bd79cf9f024d69d3f52009f94de8b
,
Jan 18 2018
The issue seems to be out of TE-scope as it is related to submitting patches to CQ. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team. Thanks...!!
,
Feb 2 2018
Petr, this is WAI because a status app url is not configured. What I don't understand is why having correct URL is important?
,
Feb 2 2018
I don't know, I never ran into this issue, kjharland@ might have more details? |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kjharland@google.com
, Dec 19 2017