UkmBrowserTest.HistoryDeleteCheck test is flaky on Windows |
|||
Issue descriptionThis is the #1 failure on the MSVC bots. Ignore the name CrWinClang, it's using MSVC, and the bot will be renamed after the clang switch sticks. https://ci.chromium.org/buildbot/chromium.clang/CrWinClang/ The flakiness dashboard shows that this is mostly specific to the MSVC release bots, which are CrWinClang and CrWinClang64: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=UkmBrowserTest.HistoryDeleteCheck The test was recently added in https://chromium-review.googlesource.com/c/chromium/src/+/818202
,
Dec 21 2017
I prepared a revert: https://chromium-review.googlesource.com/c/chromium/src/+/840862
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdf4d5eb8e20a0a66bd659400bd2729f3ca2072c commit fdf4d5eb8e20a0a66bd659400bd2729f3ca2072c Author: Reid Kleckner <rnk@google.com> Date: Thu Dec 21 20:43:07 2017 Revert "Add test coverage of UKM History delete handling." This reverts commit 2a7fbdc52318f6169ae27ef251c52d91b5480aa9. Reason for revert: This new test is flaky on Windows. Original change's description: > Add test coverage of UKM History delete handling. > > Coverage on iOS left for a follow up. > > Bug: 793470 > Change-Id: I4844e667c421f7df3c3412362d50ad74078e8223 > Reviewed-on: https://chromium-review.googlesource.com/818202 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523256} TBR=asvitkine@chromium.org,bcwhite@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 793470 , 796236 Change-Id: I43356b1e4f5bea9b71b206ffe7ef1496d9d41b7d Reviewed-on: https://chromium-review.googlesource.com/840862 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#525795} [modify] https://crrev.com/fdf4d5eb8e20a0a66bd659400bd2729f3ca2072c/chrome/browser/metrics/ukm_browsertest.cc
,
Dec 21 2017
Looking through the code a bit, I suspect that this might be due to the call to NotifyDeleteURLs not being run from message loop yet: https://cs.chromium.org/chromium/src/components/history/core/browser/history_service.cc?rcl=984f604436155b09389c7b2e396b4513dfc09a88&l=161 I think BrowsingDataRemoverCompletionObserver::BlockUntilCompletion might only block until the task that posts that task gets run? https://chromium-review.googlesource.com/c/chromium/src/+/840734 adds an extra content::RunAllPendingInMessageLoop(), not sure if there is a cleaner way to make sure that it flushed.
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ed93d0f69704598d0eae6ed6d2a1c85d2ed6a52 commit 8ed93d0f69704598d0eae6ed6d2a1c85d2ed6a52 Author: Steven Holte <holte@google.com> Date: Thu Dec 21 21:50:47 2017 Reland UKM history delete test. This adds a content::RunAllPendingInMessageLoop call to avoid flakiness. Bug: 796236 Change-Id: I45f8748315b3509b917a1dd552deabca753b0321 Reviewed-on: https://chromium-review.googlesource.com/840734 Reviewed-by: Reid Kleckner <rnk@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#525819} [modify] https://crrev.com/8ed93d0f69704598d0eae6ed6d2a1c85d2ed6a52/chrome/browser/metrics/ukm_browsertest.cc
,
Dec 27 2017
Looks like it's still flaking: https://ci.chromium.org/buildbot/chromium.clang/CrWinClang/1309
,
Jan 5 2018
Maybe https://chromium-review.googlesource.com/851448 will fix it. Last flake right before that rev: https://ci.chromium.org/buildbot/chromium.clang/CrWinClang/1480
,
Jan 8 2018
I don't see new instances of this after: https://chromium-review.googlesource.com/852831 |
|||
►
Sign in to add a comment |
|||
Comment 1 by r...@chromium.org
, Dec 19 2017