New issue
Advanced search Search tips

Issue 796231 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Understand why removeBrowsingDataFromBrowserState:mask:timePeriod:completionHandler: does not complete in 5 seconds

Project Member Reported by eugene...@chromium.org, Dec 19 2017

Issue description

ClearCertificatePolicies() often does not complete with 5 seconds timeout, which can be a problem with iOS 11. We need to add a metric and measure the average time to clear browsing data.

Context: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/532160
 
Labels: -Restrict-View-Google -Pri-2 M-65 Pri-1
Status: Assigned (was: Untriaged)
Mohammad, please add this metric to M65. We might have a problem with Browsing Data clearing on iOS 11.
Owner: mrefaat@chromium.org
Actually Assigning the bug. Mohammad, please add this metric to M65. We might have a problem with Browsing Data clearing on iOS 11.

Components: -Internals Internals>Network>Cookies
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb

commit d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb
Author: mrefaat <mrefaat@chromium.org>
Date: Wed Aug 08 22:07:53 2018

Record time spent on browsing data removal.

I added task_started time to RemovalTask structure, this was dropped
when this class was ported from content.

Bug: 796231, 759229
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I19f44ef3a72685b1fbe398e2915b8fd842307541
Reviewed-on: https://chromium-review.googlesource.com/1164571
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581704}
[modify] https://crrev.com/d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb/ios/chrome/browser/browsing_data/browsing_data_remover_impl.h
[modify] https://crrev.com/d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb/ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm
[modify] https://crrev.com/d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb/ios/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.mm

Labels: -Pri-1 Pri-2

Sign in to add a comment