kDataUriHasOctothorpe UseCounter hook can fire before commit for iframes |
|||
Issue descriptionIn ResourceFetcher::RequestResource we have a UseCounter hook for tracking data URIs that have '#' in them (see issue 123004). When adding kDataUriHasOctothorpe as a UKM-enabled metric, however, we discovered that this hook fires too early if the data URI is the source of an iframe. For the following HTML: <iframe src="data:text/html,#"></iframe> ResourceFetcher::RequestResource will occur before commit for the iframe, because commit is triggered by the first bytes of the main resource coming in. As such MetricsRenderFrameObserver will not yet have a PageTimingMetricsSender, so the UKM data will not be recorded.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db7bef5a1f702dd9758ecf954083b529233c61f4 commit db7bef5a1f702dd9758ecf954083b529233c61f4 Author: Luna Lu <loonybear@chromium.org> Date: Tue Dec 19 19:29:21 2017 Opt in feature WebFeature::kDataUriHasOctothorpe to UKM UseCounter Bug: 706389, 123004, 796173 Change-Id: I131a7936f2f2357a03f02cfcd26758ce33bbe2fa Reviewed-on: https://chromium-review.googlesource.com/833286 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#525108} [modify] https://crrev.com/db7bef5a1f702dd9758ecf954083b529233c61f4/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc [modify] https://crrev.com/db7bef5a1f702dd9758ecf954083b529233c61f4/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc [modify] https://crrev.com/db7bef5a1f702dd9758ecf954083b529233c61f4/chrome/test/data/page_load_metrics/use_counter_features.html
,
Apr 25 2018
,
Jan 11
Available, but no owner or component? Please find a component, as no one will ever find this without one. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 19 2017