New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 796168 link

Starred by 1 user
Status: Fixed
Owner:
grunell@chromium.org
Closed: Dec 2017
Cc:
marinaciocea@chromium.org
█ olka@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

WebRtcAudioDebugRecordingsBrowserTest fails

Project Member Reported by grunell@chromium.org, Dec 19 2017 
Started failing with https://chromium-review.googlesource.com/c/chromium/src/+/817739

../../content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc:160: Failure
Expected equality of these values:
  output_files.size()
    Which is: 1
  2u
    Which is: 2

and

../../content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc:313: Failure
Expected equality of these values:
  output_files.size()
    Which is: 2
  4u
    Which is: 4

Did an attempt to fix the test here: https://chromium-review.googlesource.com/c/chromium/src/+/833872

But one test case failed on Android.

Will disable the test cases and look at this tomorrow again.

Comment 1 by grunell@chromium.org, Dec 19 2017

Cc: mlamouri@chromium.org
mlamouri@: Can you please advise on how to setup the test cases.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d5169dbb37d8c8bd0f39224846c35e0c46b47a8

commit 9d5169dbb37d8c8bd0f39224846c35e0c46b47a8
Author: Henrik Grunell <grunell@chromium.org>
Date: Tue Dec 19 14:19:40 2017

Temporarily disable two test cases of WebRtcAudioDebugRecordingsBrowserTest.

Fails on all platforms. See bug.

TBR=guidou@chromium.org

Bug:  796168 
Change-Id: I7ecaccea911a5bd88fefc87b5c9986803e0430cd
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/833930
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525017}
[modify] https://crrev.com/9d5169dbb37d8c8bd0f39224846c35e0c46b47a8/content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc

Comment 3 by mlamouri@chromium.org, Dec 20 2017 

Sorry about this. I left a comment on the CL. Do you know why I did not see this breakage when landing my CL?

Comment 4 by grunell@chromium.org, Dec 21 2017 

mlamouri@: No breakage when landing the CL because the test isn't run on try bots due to currently requiring real audio devices (as for many WebRTC tests).

Fixed and re-enabled test in https://chromium-review.googlesource.com/c/chromium/src/+/833872. The fix is done to the best of my knowledge, but there may be a neater way. So, please have a look and advise on this.

Comment 5 by grunell@chromium.org, Dec 21 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment