New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796166 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

V8 auto-bisect broken

Project Member Reported by machenb...@chromium.org, Dec 19 2017

Issue description

Some puzzle pieces:
Bisect gets the target from the failure_dict:
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/v8/api.py?l=1035

This comes from the json progress indicator on V8 side:
https://cs.chromium.org/chromium/src/v8/tools/testrunner/local/progress.py?q=target_name+file:%5Esrc/v8/tools/testrunner/+package:%5Echromium$&l=367

@Michael: I suspect the value passed for unittests has changed...
s/Michael/Michal
Cc: -majeski@google.com
Owner: majeski@google.com
Status: Assigned (was: Untriaged)
Seems introduced by this change:
https://chromium-review.googlesource.com/c/v8/v8/+/798331

Before we passed the raw shell, without path and extension. E.g. d8 or unittests. 
This was by convention equal to the GN build target. Now it also contains an absolute path and possibly a .exe extension.
Status: Verified (was: Assigned)
Fixed by https://chromium-review.googlesource.com/c/v8/v8/+/833917

Sign in to add a comment